Issue 10857025: Add more code for debugging. We will revert this change when we find out the reason of corruption.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10857025: Add more code for debugging. We will revert this change when we find out the reason of corruption. (Closed)

Created:
8 years, 4 months ago by kaiwang

Modified:
8 years, 4 months ago

Reviewers:
ramant (doing other things), Ilya Sherman, jar (doing other things)

CC:
chromium-reviews, MAD, erikwright+watch_chromium.org, Ilya Sherman, jar (doing other things), brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add more code for debugging. We will revert this change when we find out the reason of corruption. See previous change for debugging: http://codereview.chromium.org/10826293/ BUG=140688 TBR=jar Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151837

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -12 lines)			Patch
	M	base/metrics/bucket_ranges.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	base/metrics/histogram.cc	View	1 2 3	6 chunks	+19 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jar (doing other things)

With the expectation that this will mostly be reverted after we finish debugging..... LGTM https://chromiumcodereview.appspot.com/10857025/diff/7002/base/metrics/histogram.cc ...

8 years, 4 months ago (2012-08-16 01:51:16 UTC) #3

kaiwang

8 years, 4 months ago (2012-08-16 01:52:52 UTC) #4

https://chromiumcodereview.appspot.com/10857025/diff/7002/base/metrics/histog...
File base/metrics/histogram.cc (right):

https://chromiumcodereview.appspot.com/10857025/diff/7002/base/metrics/histog...
base/metrics/histogram.cc:151: CHECK(previous_range < new_range);
On 2012/08/16 01:51:16, jar wrote:
> nit: CHECK_LT

Done.

Expand Messages | Collapse Messages