Issue 10857018: Upgrade Pipeline::Start() NOTREACHED() back into a CHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10857018: Upgrade Pipeline::Start() NOTREACHED() back into a CHECK(). (Closed)

Created:
8 years, 4 months ago by scherkus (not reviewing)

Modified:
8 years, 4 months ago

Reviewers:
Ami GONE FROM CHROMIUM

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Upgrade Pipeline::Start() NOTREACHED() back into a CHECK(). Unlike Seek(), calling Start() while running is a clear programmer error. If the pipeline did stop running and you called Start() again, make sure to no-op inside StartTask(). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151721

Patch Set 1 #

Total comments: 2

Patch Set 2 : check #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	media/base/pipeline.cc	View	1	2 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ami GONE FROM CHROMIUM

http://codereview.chromium.org/10857018/diff/1/media/base/pipeline.cc File media/base/pipeline.cc (right): http://codereview.chromium.org/10857018/diff/1/media/base/pipeline.cc#newcode557 media/base/pipeline.cc:557: if (state_ != kCreated) wat?

8 years, 4 months ago (2012-08-15 18:04:38 UTC) #2

Ami GONE FROM CHROMIUM

8 years, 4 months ago (2012-08-15 18:10:27 UTC) #3

lgtm

Expand Messages | Collapse Messages