Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: runtime/vm/flow_graph_compiler_arm.h

Issue 10857016: Refactored FlowGraphBuilder into a separate FlowGraph representation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Revision based on Kevin's review. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/flow_graph_compiler_ia32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_FLOW_GRAPH_COMPILER_ARM_H_ 5 #ifndef VM_FLOW_GRAPH_COMPILER_ARM_H_
6 #define VM_FLOW_GRAPH_COMPILER_ARM_H_ 6 #define VM_FLOW_GRAPH_COMPILER_ARM_H_
7 7
8 #ifndef VM_FLOW_GRAPH_COMPILER_H_ 8 #ifndef VM_FLOW_GRAPH_COMPILER_H_
9 #error Include flow_graph_compiler.h instead of flow_graph_compiler_arm.h. 9 #error Include flow_graph_compiler.h instead of flow_graph_compiler_arm.h.
10 #endif 10 #endif
11 11
12 #include "vm/flow_graph.h"
12 #include "vm/intermediate_language.h" 13 #include "vm/intermediate_language.h"
13 14
14 namespace dart { 15 namespace dart {
15 16
16 class Assembler; 17 class Assembler;
17 class Code; 18 class Code;
18 template <typename T> class GrowableArray; 19 template <typename T> class GrowableArray;
19 class ParsedFunction; 20 class ParsedFunction;
20 21
21 // Stubbed out implementation of graph compiler, bails out immediately if 22 // Stubbed out implementation of graph compiler, bails out immediately if
22 // CompileGraph is called. The rest of the public API is UNIMPLEMENTED. 23 // CompileGraph is called. The rest of the public API is UNIMPLEMENTED.
23 class FlowGraphCompiler : public FlowGraphVisitor { 24 class FlowGraphCompiler : public FlowGraphVisitor {
24 public: 25 public:
25 FlowGraphCompiler(Assembler* assembler, 26 FlowGraphCompiler(Assembler* assembler,
26 const ParsedFunction& parsed_function, 27 const FlowGraph& flow_graph,
27 const GrowableArray<BlockEntryInstr*>& blocks,
28 bool is_optimizing) 28 bool is_optimizing)
29 : FlowGraphVisitor(blocks), 29 : FlowGraphVisitor(flow_graph.reverse_postorder()),
30 parsed_function_(parsed_function), 30 parsed_function_(flow_graph.parsed_function()),
31 is_optimizing_(is_optimizing) { 31 is_optimizing_(is_optimizing) {
32 } 32 }
33 33
34 virtual ~FlowGraphCompiler() { } 34 virtual ~FlowGraphCompiler() { }
35 35
36 static bool CanOptimize(); 36 static bool CanOptimize();
37 37
38 void CompileGraph(); 38 void CompileGraph();
39 39
40 void FinalizePcDescriptors(const Code& code); 40 void FinalizePcDescriptors(const Code& code);
41 void FinalizeStackmaps(const Code& code); 41 void FinalizeStackmaps(const Code& code);
42 void FinalizeVarDescriptors(const Code& code); 42 void FinalizeVarDescriptors(const Code& code);
43 void FinalizeExceptionHandlers(const Code& code); 43 void FinalizeExceptionHandlers(const Code& code);
44 void FinalizeComments(const Code& code); 44 void FinalizeComments(const Code& code);
45 45
46 private: 46 private:
47 // Bail out of the flow graph compiler. Does not return to the caller. 47 // Bail out of the flow graph compiler. Does not return to the caller.
48 void Bailout(const char* reason); 48 void Bailout(const char* reason);
49 49
50 const ParsedFunction& parsed_function_; 50 const ParsedFunction& parsed_function_;
51 const bool is_optimizing_; 51 const bool is_optimizing_;
52 52
53 DISALLOW_COPY_AND_ASSIGN(FlowGraphCompiler); 53 DISALLOW_COPY_AND_ASSIGN(FlowGraphCompiler);
54 }; 54 };
55 55
56 } // namespace dart 56 } // namespace dart
57 57
58 #endif // VM_FLOW_GRAPH_COMPILER_ARM_H_ 58 #endif // VM_FLOW_GRAPH_COMPILER_ARM_H_
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/flow_graph_compiler_ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698