Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Issue 10857010: Fix FFmpegAudioDecoder monotonically increasing timestamp check to ignore kNoTimestamp() (Closed)

Created:
8 years, 4 months ago by acolwell GONE FROM CHROMIUM
Modified:
8 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Fix FFmpegAudioDecoder monotonically increasing timestamp check to ignore kNoTimestamp() BUG=142738 TEST=Cr142738/FFmpegRegressionTest.BasicPlayback/0 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151800

Patch Set 1 #

Patch Set 2 : Add FFmpegRegressionTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M media/ffmpeg/ffmpeg_regression_tests.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder.cc View 1 chunk +11 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
acolwell GONE FROM CHROMIUM
The clip in the bug report emits a buffer w/ kNoTimestamp() for the last buffer ...
8 years, 4 months ago (2012-08-15 00:10:06 UTC) #1
scherkus (not reviewing)
can we turn that manual test into an automated test somehow? (i.e., ffmpeg regression test ...
8 years, 4 months ago (2012-08-15 00:24:18 UTC) #2
acolwell GONE FROM CHROMIUM
On 2012/08/15 00:24:18, scherkus wrote: > can we turn that manual test into an automated ...
8 years, 4 months ago (2012-08-15 16:30:05 UTC) #3
acolwell GONE FROM CHROMIUM
PTAL... now w/ a FFmpegRegression test.
8 years, 4 months ago (2012-08-15 21:57:47 UTC) #4
scherkus (not reviewing)
lgtm!!! thanks!
8 years, 4 months ago (2012-08-15 21:58:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/10857010/3
8 years, 4 months ago (2012-08-15 21:59:28 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-16 00:24:24 UTC) #7
Change committed as 151800

Powered by Google App Engine
This is Rietveld 408576698