Added warning when URLRequestContextGetter leaks.

Added warning when URLRequestContextGetter leaks.

If URLRequestContextGetter's refcount drops to zero after the IO thread has
already gone away, the object leaks. This can be tricky to track down, so
now we emit a warning message to the logs.

BUG=142702
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151792

[Andrew T Wilson (Slow), 2012-08-15 16:57:02]

PTAL

[eroman, 2012-08-15 18:00:44]

lgtm

http://codereview.chromium.org/10857008/diff/7002/net/url_request/url_request...
File net/url_request/url_request_context_getter.cc (right):

http://codereview.chromium.org/10857008/diff/7002/net/url_request/url_request...
net/url_request/url_request_context_getter.cc:26: // Can't force-delete the
object here, because some derived classes
Please change the language to not reference chrome concepts (like "IO thread"
and "ShellURLRequestContextGetter").

This may seem silly, but conceptually the net/* directory should be a separable
module with no dependencies on Chrome, even though it is mainly intended to be
embedded into Chrome.

http://codereview.chromium.org/10857008/diff/7002/net/url_request/url_request...
net/url_request/url_request_context_getter.cc:29: DLOG(WARNING) <<
"URLRequestContextGetter leaking due to no IO thread.";
How about making this simply LOG(WARNING)?

[Andrew T Wilson (Slow), 2012-08-15 18:07:17]

https://chromiumcodereview.appspot.com/10857008/diff/7002/net/url_request/url...
File net/url_request/url_request_context_getter.cc (right):

https://chromiumcodereview.appspot.com/10857008/diff/7002/net/url_request/url...
net/url_request/url_request_context_getter.cc:26: // Can't force-delete the
object here, because some derived classes
On 2012/08/15 18:00:44, eroman wrote:
> Please change the language to not reference chrome concepts (like "IO thread"
> and "ShellURLRequestContextGetter").
> 
> This may seem silly, but conceptually the net/* directory should be a
separable
> module with no dependencies on Chrome, even though it is mainly intended to be
> embedded into Chrome.

Ah, good point. I'll do this.

https://chromiumcodereview.appspot.com/10857008/diff/7002/net/url_request/url...
net/url_request/url_request_context_getter.cc:29: DLOG(WARNING) <<
"URLRequestContextGetter leaking due to no IO thread.";
On 2012/08/15 18:00:44, eroman wrote:
> How about making this simply LOG(WARNING)?

Since this really only impacts unit tests, I figured it wasn't worth increasing
the size of the release version of chrome by including a warning.

[commit-bot: I haz the power, 2012-08-15 21:12:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/atwilson@chromium.org/10857008/11002

[commit-bot: I haz the power, 2012-08-15 23:52:33]

Change committed as 151792