Issue 10857002: Additional corruption instrumentation in safe-browsing filters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10857002: Additional corruption instrumentation in safe-browsing filters. (Closed)

Created:
8 years, 4 months ago by Scott Hess - ex-Googler

Modified:
8 years, 4 months ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Additional corruption instrumentation in safe-browsing filters. Prior instrumentation indicates potential memory corruption detected in creating the bloom filter and prefix set. Add new code to see if it's transient (probably memory corruption) or persistent (probably code flaws). BUG=71832 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151641

Patch Set 1 #

Total comments: 1

Patch Set 2 : spell fix #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -2 lines)			Patch
	M	chrome/browser/safe_browsing/safe_browsing_database.cc	View	1	3 chunks	+38 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

If the code is wrong, this should show clear results (no successful retries). Likewise if ...

8 years, 4 months ago (2012-08-14 21:06:47 UTC) #1

ramant (doing other things)

lgtm https://chromiumcodereview.appspot.com/10857002/diff/1/chrome/browser/safe_browsing/safe_browsing_database.cc File chrome/browser/safe_browsing/safe_browsing_database.cc (right): https://chromiumcodereview.appspot.com/10857002/diff/1/chrome/browser/safe_browsing/safe_browsing_database.cc#newcode300 chrome/browser/safe_browsing/safe_browsing_database.cc:300: PREFIX_SET_CREATE_PREFIX_SET_CHECKSUM_SUCCEEDED, nit: Corrosponding -> Corresponding

8 years, 4 months ago (2012-08-15 00:07:57 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/10857002/3001

8 years, 4 months ago (2012-08-15 00:13:06 UTC) #3

Change committed as 151641

Expand Messages | Collapse Messages