Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 10856002: Make tests work in Firefox. (Closed)

Created:
8 years, 4 months ago by ericu
Modified:
8 years, 4 months ago
Reviewers:
alecflett, jsbell
CC:
chromium-reviews, alecflett, dgrogan
Visibility:
Public.

Description

Make tests work in Firefox. Fix some comments. Make the tests a bit harder. Fix db deletion in testCreateAndDeleteIndex. BUG=137764 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150368

Patch Set 1 #

Patch Set 2 : comment fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -39 lines) Patch
M chrome/test/data/indexeddb/perf_shared.js View 1 8 chunks +28 lines, -14 lines 0 comments Download
M chrome/test/data/indexeddb/perf_test.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/indexeddb/perf_test.js View 1 4 chunks +37 lines, -25 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ericu
8 years, 4 months ago (2012-08-07 00:16:12 UTC) #1
alecflett
LGTM (but my lgtm doesn't count yet I think)
8 years, 4 months ago (2012-08-07 17:24:50 UTC) #2
jsbell
8 years, 4 months ago (2012-08-07 17:39:53 UTC) #3
lgtm too

Powered by Google App Engine
This is Rietveld 408576698