Issue 10855274: Fix Uniform Name Parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10855274: Fix Uniform Name Parsing (Closed)

Created:
8 years, 4 months ago by greggman

Modified:
8 years, 4 months ago

Reviewers:
Zhenyao Mo

CC:
chromium-reviews, apatrick_chromium

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix Uniform Name Parsing BUG=144007 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152707

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+174 lines, -37 lines)			Patch
M	gpu/command_buffer/client/program_info_manager.cc	View		2 chunks	+12 lines, -19 lines	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_utils.h	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_utils.cc	View		1 chunk	+33 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_utils_unittest.cc	View	1	1 chunk	+42 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/program_manager.cc	View		2 chunks	+11 lines, -18 lines	0 comments	Download
M	gpu/command_buffer/service/program_manager_unittest.cc	View		1 chunk	+63 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Zhenyao Mo

https://chromiumcodereview.appspot.com/10855274/diff/1/gpu/command_buffer/common/gles2_cmd_utils_unittest.cc File gpu/command_buffer/common/gles2_cmd_utils_unittest.cc (right): https://chromiumcodereview.appspot.com/10855274/diff/1/gpu/command_buffer/common/gles2_cmd_utils_unittest.cc#newcode214 gpu/command_buffer/common/gles2_cmd_utils_unittest.cc:214: CheckParseUniformName("u_name[0a0]", false, std::string::npos, 0, false); This is the same ...

8 years, 4 months ago (2012-08-21 22:03:37 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/10855274/5001

8 years, 4 months ago (2012-08-21 22:28:10 UTC) #4

Change committed as 152707

Expand Messages | Collapse Messages

Issue 10855274: Fix Uniform Name Parsing (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages