Safe Browsing malware interstitial redesign field trial.

chrome/browser/safe_browsing/safe_browsing_blocking_page_v2_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
+//
+// TODO(mattm): remove / merge this file with
+// safe_browsing_blocking_page_unittest.cc once the SBInterstitial field trial
+// finishes.
 
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/safe_browsing/malware_details.h"
 #include "chrome/browser/safe_browsing/safe_browsing_blocking_page.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "content/public/browser/interstitial_page.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/render_process_host.h"
@@ skipping 11 matching lines @@
 
 static const char* kGoogleURL = "http://www.google.com/";
 static const char* kGoodURL = "http://www.goodguys.com/";
 static const char* kBadURL = "http://www.badguys.com/";
 static const char* kBadURL2 = "http://www.badguys2.com/";
 static const char* kBadURL3 = "http://www.badguys3.com/";
 
 namespace {
 
 // A SafeBrowingBlockingPage class that does not create windows.
-class TestSafeBrowsingBlockingPage :  public SafeBrowsingBlockingPage {
+class TestSafeBrowsingBlockingPage :  public SafeBrowsingBlockingPageV2 {
  public:
   TestSafeBrowsingBlockingPage(SafeBrowsingService* service,
                                WebContents* web_contents,
                                const UnsafeResourceList& unsafe_resources)
-      : SafeBrowsingBlockingPage(service, web_contents, unsafe_resources) {
+      : SafeBrowsingBlockingPageV2(service, web_contents, unsafe_resources) {
     // Don't delay details at all for the unittest.
     malware_details_proceed_delay_ms_ = 0;
 
     // Don't create a view.
     interstitial_page()->DontCreateViewForTesting();
   }
 };
 
 class TestSafeBrowsingService: public SafeBrowsingService {
  public:
@@ skipping 21 matching lines @@
       SafeBrowsingService* service,
       WebContents* web_contents,
       const SafeBrowsingBlockingPage::UnsafeResourceList& unsafe_resources) {
     return new TestSafeBrowsingBlockingPage(service, web_contents,
                                             unsafe_resources);
   }
 };
 
 }  // namespace
 
-class SafeBrowsingBlockingPageTest : public ChromeRenderViewHostTestHarness {
+class SafeBrowsingBlockingPageV2Test : public ChromeRenderViewHostTestHarness {
  public:
   // The decision the user made.
   enum UserResponse {
     PENDING,
     OK,
     CANCEL
   };
 
-  SafeBrowsingBlockingPageTest()
+  SafeBrowsingBlockingPageV2Test()
       : ui_thread_(BrowserThread::UI, MessageLoop::current()),
         file_user_blocking_thread_(
             BrowserThread::FILE_USER_BLOCKING, MessageLoop::current()),
         io_thread_(BrowserThread::IO, MessageLoop::current()) {
     ResetUserResponse();
     service_ = new TestSafeBrowsingService();
   }
 
   virtual void SetUp() {
     ChromeRenderViewHostTestHarness::SetUp();
@@ skipping 80 matching lines @@
     MessageLoop::current()->RunAllPending();
   }
 
   scoped_refptr<TestSafeBrowsingService> service_;
 
  private:
   void InitResource(SafeBrowsingService::UnsafeResource* resource,
                     bool is_subresource,
                     const GURL& url) {
     resource->callback =
-        base::Bind(&SafeBrowsingBlockingPageTest::OnBlockingPageComplete,
+        base::Bind(&SafeBrowsingBlockingPageV2Test::OnBlockingPageComplete,
                    base::Unretained(this));
     resource->url = url;
     resource->is_subresource = is_subresource;
     resource->threat_type = SafeBrowsingService::URL_MALWARE;
     resource->render_process_host_id = contents()->GetRenderProcessHost()->
         GetID();
     resource->render_view_id = contents()->GetRenderViewHost()->GetRoutingID();
   }
 
   UserResponse user_response_;
   TestSafeBrowsingBlockingPageFactory factory_;
   content::TestBrowserThread ui_thread_;
   content::TestBrowserThread file_user_blocking_thread_;
   content::TestBrowserThread io_thread_;
 };
 
 // Tests showing a blocking page for a malware page and not proceeding.
-TEST_F(SafeBrowsingBlockingPageTest, MalwarePageDontProceed) {
+TEST_F(SafeBrowsingBlockingPageV2Test, MalwarePageDontProceed) {
   // Enable malware details.
   Profile* profile = Profile::FromBrowserContext(
       contents()->GetBrowserContext());
   profile->GetPrefs()->SetBoolean(prefs::kSafeBrowsingReportingEnabled, true);
 
   // Start a load.
   controller().LoadURL(GURL(kBadURL), content::Referrer(),
                        content::PAGE_TRANSITION_TYPED, std::string());
 
 
@@ skipping 13 matching lines @@
 
   // We did not proceed, the pending entry should be gone.
   EXPECT_FALSE(controller().GetPendingEntry());
 
   // A report should have been sent.
   EXPECT_EQ(1u, service_->GetDetails()->size());
   service_->GetDetails()->clear();
 }
 
 // Tests showing a blocking page for a malware page and then proceeding.
-TEST_F(SafeBrowsingBlockingPageTest, MalwarePageProceed) {
+TEST_F(SafeBrowsingBlockingPageV2Test, MalwarePageProceed) {
   // Enable malware reports.
   Profile* profile = Profile::FromBrowserContext(
       contents()->GetBrowserContext());
   profile->GetPrefs()->SetBoolean(prefs::kSafeBrowsingReportingEnabled, true);
 
   // Start a load.
   controller().LoadURL(GURL(kBadURL), content::Referrer(),
                        content::PAGE_TRANSITION_TYPED, std::string());
 
   // Simulate the load causing a safe browsing interstitial to be shown.
@@ skipping 11 matching lines @@
   // The interstitial should be gone now.
   ASSERT_FALSE(InterstitialPage::GetInterstitialPage(contents()));
 
   // A report should have been sent.
   EXPECT_EQ(1u, service_->GetDetails()->size());
   service_->GetDetails()->clear();
 }
 
 // Tests showing a blocking page for a page that contains malware subresources
 // and not proceeding.
-TEST_F(SafeBrowsingBlockingPageTest, PageWithMalwareResourceDontProceed) {
+TEST_F(SafeBrowsingBlockingPageV2Test, PageWithMalwareResourceDontProceed) {
   // Enable malware reports.
   Profile* profile = Profile::FromBrowserContext(
       contents()->GetBrowserContext());
   profile->GetPrefs()->SetBoolean(prefs::kSafeBrowsingReportingEnabled, true);
 
   // Navigate somewhere.
   Navigate(kGoogleURL, 1);
 
   // Navigate somewhere else.
   Navigate(kGoodURL, 2);
@@ skipping 14 matching lines @@
   ASSERT_EQ(1, controller().GetEntryCount());
   EXPECT_EQ(kGoogleURL, controller().GetActiveEntry()->GetURL().spec());
 
   // A report should have been sent.
   EXPECT_EQ(1u, service_->GetDetails()->size());
   service_->GetDetails()->clear();
 }
 
 // Tests showing a blocking page for a page that contains malware subresources
 // and proceeding.
-TEST_F(SafeBrowsingBlockingPageTest, PageWithMalwareResourceProceed) {
+TEST_F(SafeBrowsingBlockingPageV2Test, PageWithMalwareResourceProceed) {
   // Enable malware reports.
   Profile* profile = Profile::FromBrowserContext(
       contents()->GetBrowserContext());
   profile->GetPrefs()->SetBoolean(prefs::kSafeBrowsingReportingEnabled, true);
 
   // Navigate somewhere.
   Navigate(kGoodURL, 1);
 
   // Simulate that page loading a bad-resource triggering an interstitial.
   ShowInterstitial(true, kBadURL);
@@ skipping 11 matching lines @@
   EXPECT_EQ(kGoodURL, controller().GetActiveEntry()->GetURL().spec());
 
   // A report should have been sent.
   EXPECT_EQ(1u, service_->GetDetails()->size());
   service_->GetDetails()->clear();
 }
 
 // Tests showing a blocking page for a page that contains multiple malware
 // subresources and not proceeding.  This just tests that the extra malware
 // subresources (which trigger queued interstitial pages) do not break anything.
-TEST_F(SafeBrowsingBlockingPageTest,
+TEST_F(SafeBrowsingBlockingPageV2Test,
        PageWithMultipleMalwareResourceDontProceed) {
   // Enable malware reports.
   Profile* profile = Profile::FromBrowserContext(
       contents()->GetBrowserContext());
   profile->GetPrefs()->SetBoolean(prefs::kSafeBrowsingReportingEnabled, true);
 
   // Navigate somewhere.
   Navigate(kGoogleURL, 1);
 
   // Navigate somewhere else.
@@ skipping 18 matching lines @@
   // We did not proceed, we should be back to the first page, the 2nd one should
   // have been removed from the navigation controller.
   ASSERT_EQ(1, controller().GetEntryCount());
   EXPECT_EQ(kGoogleURL, controller().GetActiveEntry()->GetURL().spec());
 
   // A report should have been sent.
   EXPECT_EQ(1u, service_->GetDetails()->size());
   service_->GetDetails()->clear();
 }
 
-// Tests showing a blocking page for a page that contains multiple malware
-// subresources and proceeding through the first interstitial, but not the next.
-TEST_F(SafeBrowsingBlockingPageTest,
-       PageWithMultipleMalwareResourceProceedThenDontProceed) {
-  // Enable malware reports.
-  Profile* profile = Profile::FromBrowserContext(
-      contents()->GetBrowserContext());
-  profile->GetPrefs()->SetBoolean(prefs::kSafeBrowsingReportingEnabled, true);
-
-  // Navigate somewhere.
-  Navigate(kGoogleURL, 1);
-
-  // Navigate somewhere else.
-  Navigate(kGoodURL, 2);
-
-  // Simulate that page loading a bad-resource triggering an interstitial.
-  ShowInterstitial(true, kBadURL);
-
-  // More bad resources loading causing more interstitials. The new
-  // interstitials should be queued.
-  ShowInterstitial(true, kBadURL2);
-  ShowInterstitial(true, kBadURL3);
-
-  SafeBrowsingBlockingPage* sb_interstitial = GetSafeBrowsingBlockingPage();
-  ASSERT_TRUE(sb_interstitial);
-
-  // Proceed through the 1st interstitial.
-  ProceedThroughInterstitial(sb_interstitial);
-  EXPECT_EQ(OK, user_response());
-
-  // A report should have been sent.
-  EXPECT_EQ(1u, service_->GetDetails()->size());
-  service_->GetDetails()->clear();
-
-  ResetUserResponse();
-
-  // We should land to a 2nd interstitial (aggregating all the malware resources
-  // loaded while the 1st interstitial was showing).
-  sb_interstitial = GetSafeBrowsingBlockingPage();
-  ASSERT_TRUE(sb_interstitial);
-
-  // Don't proceed through the 2nd interstitial.
-  DontProceedThroughSubresourceInterstitial(sb_interstitial);
-  EXPECT_EQ(CANCEL, user_response());
-  EXPECT_FALSE(GetSafeBrowsingBlockingPage());
-
-  // We did not proceed, we should be back to the first page, the 2nd one should
-  // have been removed from the navigation controller.
-  ASSERT_EQ(1, controller().GetEntryCount());
-  EXPECT_EQ(kGoogleURL, controller().GetActiveEntry()->GetURL().spec());
-
-  // No report should have been sent -- we don't create a report the
-  // second time.
-  EXPECT_EQ(0u, service_->GetDetails()->size());
-  service_->GetDetails()->clear();
-}
-
-// Tests showing a blocking page for a page that contains multiple malware
-// subresources and proceeding through the multiple interstitials.
-TEST_F(SafeBrowsingBlockingPageTest, PageWithMultipleMalwareResourceProceed) {
-  // Enable malware reports.
-  Profile* profile = Profile::FromBrowserContext(
-      contents()->GetBrowserContext());
-  profile->GetPrefs()->SetBoolean(prefs::kSafeBrowsingReportingEnabled, true);
-
-  // Navigate somewhere else.
-  Navigate(kGoodURL, 1);
-
-  // Simulate that page loading a bad-resource triggering an interstitial.
-  ShowInterstitial(true, kBadURL);
-
-  // More bad resources loading causing more interstitials. The new
-  // interstitials should be queued.
-  ShowInterstitial(true, kBadURL2);
-  ShowInterstitial(true, kBadURL3);
-
-  SafeBrowsingBlockingPage* sb_interstitial = GetSafeBrowsingBlockingPage();
-  ASSERT_TRUE(sb_interstitial);
-
-  // Proceed through the 1st interstitial.
-  ProceedThroughInterstitial(sb_interstitial);
-  EXPECT_EQ(OK, user_response());
-
-  // A report should have been sent.
-  EXPECT_EQ(1u, service_->GetDetails()->size());
-  service_->GetDetails()->clear();
-
-  ResetUserResponse();
-
-  // We should land to a 2nd interstitial (aggregating all the malware resources
-  // loaded while the 1st interstitial was showing).
-  sb_interstitial = GetSafeBrowsingBlockingPage();
-  ASSERT_TRUE(sb_interstitial);
-
-  // Proceed through the 2nd interstitial.
-  ProceedThroughInterstitial(sb_interstitial);
-  EXPECT_EQ(OK, user_response());
-
-  // We did proceed, we should be back to the initial page.
-  ASSERT_EQ(1, controller().GetEntryCount());
-  EXPECT_EQ(kGoodURL, controller().GetActiveEntry()->GetURL().spec());
-
-  // No report should have been sent -- we don't create a report the
-  // second time.
-  EXPECT_EQ(0u, service_->GetDetails()->size());
-  service_->GetDetails()->clear();
-}
-
 // Tests showing a blocking page then navigating back and forth to make sure the
 // controller entries are OK.  http://crbug.com/17627
-TEST_F(SafeBrowsingBlockingPageTest, NavigatingBackAndForth) {
+TEST_F(SafeBrowsingBlockingPageV2Test, NavigatingBackAndForth) {
   // Enable malware reports.
   Profile* profile = Profile::FromBrowserContext(
       contents()->GetBrowserContext());
   profile->GetPrefs()->SetBoolean(prefs::kSafeBrowsingReportingEnabled, true);
 
   // Navigate somewhere.
   Navigate(kGoodURL, 1);
 
   // Now navigate to a bad page triggerring an interstitial.
   controller().LoadURL(GURL(kBadURL), content::Referrer(),
@@ skipping 27 matching lines @@
   ASSERT_EQ(2, controller().GetEntryCount());
   EXPECT_EQ(kBadURL, controller().GetActiveEntry()->GetURL().spec());
 
   // Two reports should have been sent.
   EXPECT_EQ(2u, service_->GetDetails()->size());
   service_->GetDetails()->clear();
 }
 
 // Tests that calling "don't proceed" after "proceed" has been called doesn't
 // cause problems. http://crbug.com/30079
-TEST_F(SafeBrowsingBlockingPageTest, ProceedThenDontProceed) {
+TEST_F(SafeBrowsingBlockingPageV2Test, ProceedThenDontProceed) {
   // Enable malware reports.
   Profile* profile = Profile::FromBrowserContext(
       contents()->GetBrowserContext());
   profile->GetPrefs()->SetBoolean(prefs::kSafeBrowsingReportingEnabled, true);
 
   // Start a load.
   controller().LoadURL(GURL(kBadURL), content::Referrer(),
                        content::PAGE_TRANSITION_TYPED, std::string());
 
   // Simulate the load causing a safe browsing interstitial to be shown.
@@ skipping 14 matching lines @@
   // The interstitial should be gone.
   EXPECT_EQ(OK, user_response());
   EXPECT_FALSE(GetSafeBrowsingBlockingPage());
 
   // Only one report should have been sent.
   EXPECT_EQ(1u, service_->GetDetails()->size());
   service_->GetDetails()->clear();
 }
 
 // Tests showing a blocking page for a malware page with reports disabled.
-TEST_F(SafeBrowsingBlockingPageTest, MalwareReportsDisabled) {
+TEST_F(SafeBrowsingBlockingPageV2Test, MalwareReportsDisabled) {
   // Disable malware reports.
   Profile* profile = Profile::FromBrowserContext(
       contents()->GetBrowserContext());
   profile->GetPrefs()->SetBoolean(prefs::kSafeBrowsingReportingEnabled, false);
 
   // Start a load.
   controller().LoadURL(GURL(kBadURL), content::Referrer(),
                        content::PAGE_TRANSITION_TYPED, std::string());
 
   // Simulate the load causing a safe browsing interstitial to be shown.
@@ skipping 12 matching lines @@
 
   // We did not proceed, the pending entry should be gone.
   EXPECT_FALSE(controller().GetPendingEntry());
 
   // No report should have been sent.
   EXPECT_EQ(0u, service_->GetDetails()->size());
   service_->GetDetails()->clear();
 }
 
 // Test setting the malware report preferance
-TEST_F(SafeBrowsingBlockingPageTest, MalwareReports) {
+TEST_F(SafeBrowsingBlockingPageV2Test, MalwareReports) {
   // Disable malware reports.
   Profile* profile = Profile::FromBrowserContext(
       contents()->GetBrowserContext());
   profile->GetPrefs()->SetBoolean(prefs::kSafeBrowsingReportingEnabled, false);
 
   // Start a load.
   controller().LoadURL(GURL(kBadURL), content::Referrer(),
                        content::PAGE_TRANSITION_TYPED, std::string());
 
   // Simulate the load causing a safe browsing interstitial to be shown.
@@ skipping 11 matching lines @@
 
   EXPECT_TRUE(profile->GetPrefs()->GetBoolean(
       prefs::kSafeBrowsingReportingEnabled));
 
   // Simulate the user uncheck the report agreement checkbox.
   sb_interstitial->SetReportingPreference(false);
 
   EXPECT_FALSE(profile->GetPrefs()->GetBoolean(
       prefs::kSafeBrowsingReportingEnabled));
 }