Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(151)

Issue 10855251: Merge 126043 - webkitfullscreenchange not fired properly in iframe. (Closed)

Created:
8 years, 1 month ago by karen
Modified:
8 years, 1 month ago
Reviewers:
bbudge
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1229/
Visibility:
Public.

Description

Merge 126043 - webkitfullscreenchange not fired properly in iframe. https://bugs.webkit.org/show_bug.cgi?id=93525 Reviewed by Adam Barth. webkitCancelFullScreen exits fullscreen by invoking webkitExitFullScreen on topDocument. However, if webkitDidExitFullScreenForElement is invoked on a descendant document, no events get dispatched. This change starts the event dispatch delay timer on the document where webkitCancelFullScreen was called, so that the events get dispatched. In addition, when events are dispatched, the check whether a node has been removed is changed to also check that the node isn't in another document, as can happen with frames. Finally, webkitExitFullscreen is fixed to remove unnecessary code and conform to the spec. No new tests (the existing fullscreen/exit-full-screen-iframe.html test now passes). * dom/Document.cpp: (WebCore::Document::webkitExitFullscreen): (WebCore::Document::webkitDidExitFullScreenForElement): (WebCore::Document::fullScreenChangeDelayTimerFired): TBR=bbudge@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126050

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M Source/WebCore/dom/Document.cpp View 5 chunks +17 lines, -10 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
karen
8 years, 1 month ago (2012-08-20 19:03:42 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698