remoting/host/me2me_preference_pane.mm - Issue 10855249: [Chromoting] The daemon process now starts the networking process and passes the host configuration…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/me2me_preference_pane.mm

Issue 10855249: [Chromoting] The daemon process now starts the networking process and passes the host configuration… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: CR feedback and rebased on top of https://chromiumcodereview.appspot.com/10829467/ Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/host/me2me_preference_pane.mm

diff --git a/remoting/host/me2me_preference_pane.mm b/remoting/host/me2me_preference_pane.mm

index f3fa2d4e567cf94d714c0dafd8db4b533a3840be..a2a342f181247c77be6bf676202cda8c2d6060b0 100644

--- a/remoting/host/me2me_preference_pane.mm

+++ b/remoting/host/me2me_preference_pane.mm

@@ -523,17 +523,8 @@ std::string JsonHostConfig::GetSerializedData() const {

have_new_config_ = NO;

- // If the service is running, send a signal to cause it to reload its

- // configuration, otherwise start the service.

- if (is_service_running_) {

- pid_t job_pid = base::mac::PIDForJob(remoting::kServiceName);

- if (job_pid > 0) {

- kill(job_pid, SIGHUP);

- } else {

- NSLog(@"Failed to obtain PID of service %s", remoting::kServiceName);

- [self showError];

- }

- } else {

+ // Start the service.

Wez 2012/08/24 22:20:38 nit: "Ensure the service is started".

alexeypa (please no reviews) 2012/08/27 23:16:41 Done.

+ if (!is_service_running_) {

[self sendJobControlMessage:LAUNCH_KEY_STARTJOB];

}

« remoting/host/daemon_process.cc ('K') | « remoting/host/json_host_config.cc ('k') | remoting/host/posix/sighup_listener.h » ('j') | remoting/host/remoting_me2me_host.cc » ('J')