Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: remoting/host/me2me_preference_pane.mm

Issue 10855249: [Chromoting] The daemon process now starts the networking process and passes the host configuration… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: CR feedback + rebased on top of https://chromiumcodereview.appspot.com/10829467/ (Patch Set 5) Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/me2me_preference_pane.mm
diff --git a/remoting/host/me2me_preference_pane.mm b/remoting/host/me2me_preference_pane.mm
index f3fa2d4e567cf94d714c0dafd8db4b533a3840be..261ea2f90c72ca76b42351707afbc8c070680c7e 100644
--- a/remoting/host/me2me_preference_pane.mm
+++ b/remoting/host/me2me_preference_pane.mm
@@ -523,17 +523,8 @@ std::string JsonHostConfig::GetSerializedData() const {
have_new_config_ = NO;
- // If the service is running, send a signal to cause it to reload its
- // configuration, otherwise start the service.
- if (is_service_running_) {
- pid_t job_pid = base::mac::PIDForJob(remoting::kServiceName);
- if (job_pid > 0) {
- kill(job_pid, SIGHUP);
- } else {
- NSLog(@"Failed to obtain PID of service %s", remoting::kServiceName);
- [self showError];
- }
- } else {
+ // Ensure the service is started.
+ if (!is_service_running_) {
[self sendJobControlMessage:LAUNCH_KEY_STARTJOB];
}

Powered by Google App Engine
This is Rietveld 408576698