Remove the --enable-device-policy and --enable-onc-policy flags.

Remove the --enable-device-policy and --enable-onc-policy flags.

These features are stable and are always enabled on Chrome OS.

BUG=143164
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153000

[Joao da Silva, 2012-08-20 14:27:29]

@mnissler: please review

@satorux: please review chromeos/

@thakis: OWNER stamp for chrome/common/

Thanks!

[Mattias Nissler (ping if slow), 2012-08-20 14:29:05]

LGTM

[Nico, 2012-08-20 14:36:30]

lgtm

[satorux1, 2012-08-20 16:18:31]

chromeos lgtm

[Joao da Silva, 2012-08-23 11:22:46]

@mnissler: PTAL. A couple of tests have new expectations that are required now
that device policy is always enabled. User cloud policy is also not started when
in guest mode, to avoid a NOTREACHED when parsing the username.

[Mattias Nissler (ping if slow), 2012-08-23 11:37:51]

LGTM with a nit.

http://codereview.chromium.org/10855244/diff/15002/chrome/browser/chromeos/ch...
File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (right):

http://codereview.chromium.org/10855244/diff/15002/chrome/browser/chromeos/ch...
chrome/browser/chromeos/chrome_browser_main_chromeos.cc:386: // initialization
code sees policy settings. Skip this for guest logins.
nit: This comment adjustment doesn't make sense, I can see that we're doing that
from looking at the code. You might want to mention that guest accounts are not
subject to user policy though :)

[commit-bot: I haz the power, 2012-08-23 12:59:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/10855244/23004

[Joao da Silva, 2012-08-23 12:59:12]

Thanks for the review!

http://codereview.chromium.org/10855244/diff/15002/chrome/browser/chromeos/ch...
File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (right):

http://codereview.chromium.org/10855244/diff/15002/chrome/browser/chromeos/ch...
chrome/browser/chromeos/chrome_browser_main_chromeos.cc:386: // initialization
code sees policy settings. Skip this for guest logins.
On 2012/08/23 11:37:51, Mattias Nissler wrote:
> nit: This comment adjustment doesn't make sense, I can see that we're doing
that
> from looking at the code. You might want to mention that guest accounts are
not
> subject to user policy though :)

Done.

[commit-bot: I haz the power, 2012-08-23 16:06:35]

Change committed as 153000

[Dmitry Polukhin, 2012-08-30 08:48:53]

https://chromiumcodereview.appspot.com/10855244/diff/23004/chrome/browser/chr...
File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (right):

https://chromiumcodereview.appspot.com/10855244/diff/23004/chrome/browser/chr...
chrome/browser/chromeos/chrome_browser_main_chromeos.cc:391:
chromeos::UserManager::Get()->SessionStarted();
Putting SessionStarted into !IsLoggedInAsGuest broke guest mode on Chrome OS,
see  http://code.google.com/p/chromium/issues/detail?id=145116