Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 10855231: Make content_browsertests support restarts across a test. (Closed)

Created:
8 years, 4 months ago by jam
Modified:
8 years, 4 months ago
Reviewers:
scottmg
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Make content_browsertests support restarts across a test. BUG=90448 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152174

Patch Set 1 #

Total comments: 2

Patch Set 2 : Allow _CRASH suffix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -25 lines) Patch
M chrome/test/base/chrome_test_launcher.cc View 4 chunks +2 lines, -18 lines 0 comments Download
M content/public/test/test_launcher.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/public/test/test_launcher.cc View 1 3 chunks +17 lines, -2 lines 0 comments Download
M content/shell/shell_browser_context.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M content/shell/shell_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/shell_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/test/content_test_launcher.cc View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
8 years, 4 months ago (2012-08-17 20:51:35 UTC) #1
scottmg
lgtm http://codereview.chromium.org/10855231/diff/1/chrome/test/base/chrome_test_launcher.cc File chrome/test/base/chrome_test_launcher.cc (left): http://codereview.chromium.org/10855231/diff/1/chrome/test/base/chrome_test_launcher.cc#oldcode95 chrome/test/base/chrome_test_launcher.cc:95: // CreateUniqueTempDir will succeed even if deleting the ...
8 years, 4 months ago (2012-08-17 21:00:06 UTC) #2
jam
http://codereview.chromium.org/10855231/diff/1/chrome/test/base/chrome_test_launcher.cc File chrome/test/base/chrome_test_launcher.cc (left): http://codereview.chromium.org/10855231/diff/1/chrome/test/base/chrome_test_launcher.cc#oldcode95 chrome/test/base/chrome_test_launcher.cc:95: // CreateUniqueTempDir will succeed even if deleting the directory ...
8 years, 4 months ago (2012-08-17 21:08:04 UTC) #3
jam
Scott: I added a small change that allows PRE_* tests with _CRASH suffix to work ...
8 years, 4 months ago (2012-08-17 22:08:56 UTC) #4
scottmg
8 years, 4 months ago (2012-08-17 22:10:59 UTC) #5
lgtm++

Powered by Google App Engine
This is Rietveld 408576698