Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 10855219: Fixing the javascript alert window title for being translated completely. (Closed)

Created:
8 years, 4 months ago by jakob.j.w
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://src.chromium.org/chrome/trunk/src/chrome/app/
Visibility:
Public.

Description

Fixing the javascript alert window title for being translated completely. BUG=101381, 77451 TEST=Occurs after the corresponding translations are made. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152409

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M generated_resources.grd View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
commit-bot: I haz the power
No reviewers yet.
8 years, 4 months ago (2012-08-17 10:19:39 UTC) #1
jakob.j.w
8 years, 4 months ago (2012-08-17 10:24:36 UTC) #2
jakob.j.w
8 years, 4 months ago (2012-08-19 14:08:22 UTC) #3
jakob.j.w
8 years, 4 months ago (2012-08-19 14:12:08 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 4 months ago (2012-08-20 09:51:43 UTC) #5
csilv
lgtm
8 years, 4 months ago (2012-08-20 17:04:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jakob.j.w@googlemail.com/10855219/1
8 years, 4 months ago (2012-08-20 17:13:11 UTC) #7
commit-bot: I haz the power
Presubmit check for 10855219-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-20 17:13:13 UTC) #8
csilv
Hi Jakob, Thank you very much for your patch. We don't currently have you signed ...
8 years, 4 months ago (2012-08-20 17:24:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jakob.j.w@googlemail.com/10855219/1
8 years, 4 months ago (2012-08-20 18:22:43 UTC) #10
commit-bot: I haz the power
8 years, 4 months ago (2012-08-20 22:24:00 UTC) #11
Change committed as 152409

Powered by Google App Engine
This is Rietveld 408576698