Correct channel mask on android

On mono mode, SL_SPEAKER_FRONT_CENTER is the channel mask;
On Stereo mode, SL_SPEAKER_FRONT_LEFT | SL_SPEAKER_FRONT_RIGHT should be used.

For channel more than 2, we don't support it yet.


BUG=143352
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152313

[no longer working on chromium, 2012-08-17 09:07:04]

Please review

[Raymond Toy (Google), 2012-08-17 16:14:33]

LGTM with just a couple of really minor nits.

I can confirm that the two channel support works because that's what I did to
get webaudio running on android.

https://chromiumcodereview.appspot.com/10855218/diff/1/media/audio/android/op...
File media/audio/android/opensles_input.cc (right):

https://chromiumcodereview.appspot.com/10855218/diff/1/media/audio/android/op...
media/audio/android/opensles_input.cc:33: NOTREACHED() << "Unsupported channel "
<< format_.numChannels;
Nit:  I would say "Unsupported number of channels: "

https://chromiumcodereview.appspot.com/10855218/diff/1/media/audio/android/op...
File media/audio/android/opensles_output.cc (right):

https://chromiumcodereview.appspot.com/10855218/diff/1/media/audio/android/op...
media/audio/android/opensles_output.cc:35: NOTREACHED() << "Unsupported channel
" << format_.numChannels;
Nit:  I would say "Unsupported number of channels: "

[scherkus (not reviewing), 2012-08-17 17:47:12]

lgtm w/ one question/nit

https://chromiumcodereview.appspot.com/10855218/diff/1/media/audio/android/op...
File media/audio/android/opensles_input.cc (right):

https://chromiumcodereview.appspot.com/10855218/diff/1/media/audio/android/op...
media/audio/android/opensles_input.cc:33: NOTREACHED() << "Unsupported channel "
<< format_.numChannels;
do we need to set channelMask to something or is there a default value?

https://chromiumcodereview.appspot.com/10855218/diff/1/media/audio/android/op...
File media/audio/android/opensles_output.cc (right):

https://chromiumcodereview.appspot.com/10855218/diff/1/media/audio/android/op...
media/audio/android/opensles_output.cc:35: NOTREACHED() << "Unsupported channel
" << format_.numChannels;
ditto

[no longer working on chromium, 2012-08-20 09:29:45]

http://codereview.chromium.org/10855218/diff/1/media/audio/android/opensles_i...
File media/audio/android/opensles_input.cc (right):

http://codereview.chromium.org/10855218/diff/1/media/audio/android/opensles_i...
media/audio/android/opensles_input.cc:33: NOTREACHED() << "Unsupported channel "
<< format_.numChannels;
On 2012/08/17 16:14:33, rtoy wrote:
> Nit:  I would say "Unsupported number of channels: "

Done.

http://codereview.chromium.org/10855218/diff/1/media/audio/android/opensles_i...
media/audio/android/opensles_input.cc:33: NOTREACHED() << "Unsupported channel "
<< format_.numChannels;
On 2012/08/17 17:47:12, scherkus wrote:
> do we need to set channelMask to something or is there a default value?

Good question.
When the mask does not match the channel number, we will hit a
SL_RESULT_PARAMETER_INVALID error when creating the recorder or player. Which
should the same as not setting the mask.
So setting a default value here does not make any difference  here.

[commit-bot: I haz the power, 2012-08-20 09:30:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xians@chromium.org/10855218/5001

[commit-bot: I haz the power, 2012-08-20 11:17:21]

Change committed as 152313