Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 10855202: Upstream binary files for Android NTP resources. (Closed)

Created:
8 years, 4 months ago by Yaron
Modified:
8 years, 4 months ago
Reviewers:
newt (away), Evan Stade
CC:
chromium-reviews, arv (Not doing code reviews)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Upstream binary files for Android NTP resources. Contributed by: newt@chromium.org BUG=136951 TBR=estade@chromium.org (copied from http://codereview.chromium.org/10854167/ so I can dcommit for newt@) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151915

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-39 lines, --39 lines) Patch
A chrome/browser/resources/ntp_android/images/bookmark_bg_hdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/bookmark_bg_mdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/bookmark_bg_tvdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/bookmark_bg_xhdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/bookmark_border_hdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/bookmark_border_mdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/bookmark_border_tvdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/bookmark_border_xhdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/bookmark_folder_hdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/bookmark_folder_mdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/bookmark_folder_tvdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/bookmark_folder_xhdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/breadcrumb_hdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/breadcrumb_mdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/breadcrumb_tvdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/breadcrumb_xhdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/default_thumbnail.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/disclosure_closed_hdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/disclosure_closed_mdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/disclosure_closed_xhdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/disclosure_open_hdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/disclosure_open_mdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/disclosure_open_xhdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/laptop_hdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/laptop_mdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/laptop_xhdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/phone_hdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/phone_mdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/phone_xhdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/sent_hdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/sent_mdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/sent_xhdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/syncfographic_hdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/syncfographic_mdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/syncfographic_xhdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/tablet_hdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/tablet_mdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/tablet_xhdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/ntp_android/images/welcome_thumb.png View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yaron
Going to dcommit on behalf of newt
8 years, 4 months ago (2012-08-16 17:42:34 UTC) #1
newt (away)
lgtm, thanks!
8 years, 4 months ago (2012-08-16 17:43:24 UTC) #2
Evan Stade
On 2012/08/16 17:43:24, newt wrote: > lgtm, thanks! it's best to pass -c so that ...
8 years, 4 months ago (2012-08-16 18:59:51 UTC) #3
Yaron
Hrmm. I did: git cl dcommit -c 'Newton Allen <newt@chromium.org>' On Thu, Aug 16, 2012 ...
8 years, 4 months ago (2012-08-16 19:05:07 UTC) #4
Evan Stade
8 years, 4 months ago (2012-08-16 20:21:29 UTC) #5
oh, I guess it just added the one line at the bottom of the commit
description. I thought it would magically change the commit author.
Nevermind, carry on.


-- Evan Stade


On Thu, Aug 16, 2012 at 12:04 PM, Yaron Friedman <yfriedman@chromium.org>wrote:

> Hrmm. I did: git cl dcommit -c 'Newton Allen <newt@chromium.org>'
>
> On Thu, Aug 16, 2012 at 11:59 AM,  <estade@chromium.org> wrote:
> > On 2012/08/16 17:43:24, newt wrote:
> >>
> >> lgtm, thanks!
> >
> >
> > it's best to pass -c so that git gets the right author. See git cl help
> > dcommit
> >
> > http://codereview.chromium.org/10855202/
>

Powered by Google App Engine
This is Rietveld 408576698