Disable sync for default apps

chrome/common/extensions/extension_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension.h"
 
 #include "base/format_macros.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/json/json_file_value_serializer.h"
@@ skipping 1037 matching lines @@
   USER_SCRIPT,
   THEME
 };
 
 static scoped_refptr<Extension> MakeSyncTestExtension(
     SyncTestExtensionType type,
     const GURL& update_url,
     const GURL& launch_url,
     Extension::Location location,
     int num_plugins,
-    const FilePath& extension_path) {
+    const FilePath& extension_path,
+    int creation_flags=Extension::NO_FLAGS) {

[Mihai Parparita -not on Chrome, 2012/08/24 21:05:23]

Our style guide forbids default arguments:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Default_Arguments

   DictionaryValue source;
   source.SetString(extension_manifest_keys::kName,
                    "PossiblySyncableExtension");
   source.SetString(extension_manifest_keys::kVersion, "0.0.0.0");
   if (type == APP)
     source.SetString(extension_manifest_keys::kApp, "true");
   if (type == THEME)
     source.Set(extension_manifest_keys::kTheme, new DictionaryValue());
   if (!update_url.is_empty()) {
     source.SetString(extension_manifest_keys::kUpdateURL,
@@ skipping 10 matching lines @@
     for (int i = 0; i < num_plugins; ++i) {
       DictionaryValue* plugin = new DictionaryValue();
       plugin->SetString(extension_manifest_keys::kPluginsPath, "");
       plugins->Set(i, plugin);
     }
     source.Set(extension_manifest_keys::kPlugins, plugins);
   }
 
   std::string error;
   scoped_refptr<Extension> extension = Extension::Create(
-      extension_path, location, source, Extension::NO_FLAGS, &error);
+      extension_path, location, source, creation_flags, &error);
   EXPECT_TRUE(extension);
   EXPECT_EQ("", error);
   return extension;
 }
 
 static const char kValidUpdateUrl1[] =
     "http://clients2.google.com/service/update2/crx";
 static const char kValidUpdateUrl2[] =
     "https://clients2.google.com/service/update2/crx";
 }
@@ skipping 65 matching lines @@
       MakeSyncTestExtension(EXTENSION, GURL(), GURL(),
                             Extension::INTERNAL, 0, FilePath()));
   EXPECT_TRUE(extension_internal->IsSyncable());
 
   scoped_refptr<Extension> extension_noninternal(
       MakeSyncTestExtension(EXTENSION, GURL(), GURL(),
                             Extension::COMPONENT, 0, FilePath()));
   EXPECT_FALSE(extension_noninternal->IsSyncable());
 }
 
+TEST(ExtensionTest, DontSyncDefault) {
+  scoped_refptr<Extension> extension_default(
+      MakeSyncTestExtension(EXTENSION, GURL(), GURL(),
+                            Extension::INTERNAL, 0, FilePath(),
+                            Extension::FROM_DEFAULT));
+  EXPECT_FALSE(extension_default->IsSyncable());
+}
+
 // These last 2 tests don't make sense on Chrome OS, where extension plugins
 // are not allowed.
 #if !defined(OS_CHROMEOS)
 TEST(ExtensionTest, GetSyncTypeExtensionWithPlugin) {
   scoped_refptr<Extension> extension(
       MakeSyncTestExtension(EXTENSION, GURL(), GURL(),
                             Extension::INTERNAL, 1, FilePath()));
   if (extension)
     EXPECT_EQ(extension->GetSyncType(), Extension::SYNC_TYPE_NONE);
 }
 
 TEST(ExtensionTest, GetSyncTypeExtensionWithTwoPlugins) {
   scoped_refptr<Extension> extension(
       MakeSyncTestExtension(EXTENSION, GURL(), GURL(),
                             Extension::INTERNAL, 2, FilePath()));
   if (extension)
     EXPECT_EQ(extension->GetSyncType(), Extension::SYNC_TYPE_NONE);
 }
 #endif // !defined(OS_CHROMEOS)