lib/compiler/implementation/ssa/optimize.dart - Issue 10855174: Lazy implementation of final variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/ssa/optimize.dart

Issue 10855174: Lazy implementation of final variables. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments and move some code from compiler to backend. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/compiler/implementation/ssa/optimize.dart

diff --git a/lib/compiler/implementation/ssa/optimize.dart b/lib/compiler/implementation/ssa/optimize.dart

index 0e2843d29d55f822c51a86b4347847ae1195e732..b20e5a475052742f1f4011f244a0c52157520f93 100644

--- a/lib/compiler/implementation/ssa/optimize.dart

+++ b/lib/compiler/implementation/ssa/optimize.dart

@@ -52,6 +52,10 @@ class SsaOptimizerTask extends CompilerTask {

}

bool trySpeculativeOptimizations(WorkItem work, HGraph graph) {

+ if (work.element.isField()) {

+ // Lazy initializers may not have bailout methods.

+ return false;

+ }

JavaScriptItemCompilationContext context = work.compilationContext;

HTypeMap types = context.types;

return measure(() {