Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 10855171: Add a test runner for android_webview. (Closed)

Created:
8 years, 4 months ago by mkosiba (inactive)
Modified:
8 years, 4 months ago
Reviewers:
Yaron, Jói, Torne
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, joth, Leandro Graciá Gil, android-webview-reviews_google.com
Visibility:
Public.

Description

Add a test runner for android_webview. This change adds the necessary build rules for an android_webview test APK and test runner APK and a trivial test case. This change also adds a static Java library target to the WebContentsDelegateAndroid component. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153046

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase + update #

Total comments: 3

Patch Set 4 : remove infobars dep, add DEPS file to chrome/android/java #

Total comments: 1

Patch Set 5 : use private object for synchronization in CallbackHelper #

Patch Set 6 : add license to AndroiWebViewTestRunnerApplication #

Total comments: 2

Patch Set 7 : address feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1894 lines, -124 lines) Patch
M android_webview/DEPS View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A android_webview/aw_browser.gypi View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
A android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc View 1 2 1 chunk +44 lines, -0 lines 0 comments Download
A android_webview/java/AndroidManifest.xml View 1 chunk +28 lines, -0 lines 0 comments Download
A android_webview/java/android_webview_apk.xml View 1 2 1 chunk +45 lines, -0 lines 0 comments Download
A android_webview/java/src/org/chromium/android_webview/AndroidWebViewUtil.java View 1 chunk +25 lines, -0 lines 0 comments Download
A android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 2 1 chunk +83 lines, -0 lines 0 comments Download
A android_webview/java/src/org/chromium/android_webview/InterceptedRequestData.java View 1 chunk +39 lines, -0 lines 0 comments Download
A android_webview/javatests/AndroidManifest.xml View 1 chunk +24 lines, -0 lines 0 comments Download
A android_webview/javatests/DEPS View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A android_webview/javatests/android_webview_test_apk.xml View 1 chunk +55 lines, -0 lines 0 comments Download
A android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewLoadUrlTest.java View 1 2 1 chunk +72 lines, -0 lines 0 comments Download
A android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java View 1 2 1 chunk +134 lines, -0 lines 0 comments Download
A android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestRunnerActivity.java View 1 chunk +94 lines, -0 lines 0 comments Download
A android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestRunnerApplication.java View 1 2 3 4 5 1 chunk +46 lines, -0 lines 0 comments Download
A android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java View 1 2 1 chunk +64 lines, -0 lines 0 comments Download
M android_webview/lib/DEPS View 1 2 3 1 chunk +12 lines, -1 line 0 comments Download
M android_webview/lib/android_webview.gyp View 1 2 2 chunks +248 lines, -10 lines 0 comments Download
A android_webview/lib/aw_browser_dependency_factory_impl.h View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
A android_webview/lib/aw_browser_dependency_factory_impl.cc View 1 2 1 chunk +70 lines, -0 lines 0 comments Download
A android_webview/lib/aw_content_browser_client.h View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
A android_webview/lib/aw_content_browser_client.cc View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
M android_webview/lib/main/webview_main_delegate.cc View 1 2 3 chunks +5 lines, -2 lines 0 comments Download
A android_webview/native/android_web_view_util.h View 1 chunk +13 lines, -0 lines 0 comments Download
A android_webview/native/android_web_view_util.cc View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
M android_webview/native/android_webview_jni_registrar.cc View 1 2 1 chunk +12 lines, -1 line 0 comments Download
A android_webview/native/aw_browser_dependency_factory.h View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
A android_webview/native/aw_browser_dependency_factory.cc View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
A android_webview/native/aw_contents.h View 1 2 1 chunk +51 lines, -0 lines 0 comments Download
A android_webview/native/aw_contents.cc View 1 2 1 chunk +66 lines, -0 lines 0 comments Download
A android_webview/native/aw_contents_container.h View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
A android_webview/native/intercepted_request_data.h View 1 chunk +31 lines, -0 lines 0 comments Download
A android_webview/native/intercepted_request_data.cc View 1 chunk +55 lines, -0 lines 0 comments Download
M android_webview/native/webview_native.gyp View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M base/android/jni_generator/jni_generator.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/java/DEPS View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/component/web_contents_delegate_android/WebContentsDelegateAndroid.java View 1 2 1 chunk +0 lines, -110 lines 0 comments Download
M chrome/browser/component/components.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/component/web_contents_delegate_android/java/src/org/chromium/chrome/browser/component/web_contents_delegate_android/WebContentsDelegateAndroid.java View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/component/web_contents_delegate_android/web_contents_delegate_android.gypi View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/LoadUrlParams.java View 1 1 chunk +22 lines, -0 lines 0 comments Download
A content/public/android/javatests/src/org/chromium/content/browser/test/CallbackHelper.java View 1 2 3 4 5 6 1 chunk +93 lines, -0 lines 0 comments Download
A content/public/android/javatests/src/org/chromium/content/browser/test/TestContentViewClient.java View 1 chunk +152 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mkosiba (inactive)
8 years, 4 months ago (2012-08-15 09:47:23 UTC) #1
mkosiba (inactive)
Joi, Could you please take a look at DEPS changes? Torne, Could you please take ...
8 years, 4 months ago (2012-08-23 14:24:07 UTC) #2
Jói
DEPS LGTM. https://chromiumcodereview.appspot.com/10855171/diff/6001/android_webview/lib/DEPS File android_webview/lib/DEPS (right): https://chromiumcodereview.appspot.com/10855171/diff/6001/android_webview/lib/DEPS#newcode21 android_webview/lib/DEPS:21: "!chrome/browser/api/infobars/confirm_infobar_delegate.h", This dependency would be OK as ...
8 years, 4 months ago (2012-08-23 14:27:46 UTC) #3
mkosiba (inactive)
After re-running checkdeps it seems I'll need to add a DEPS file under chrome/android/java to ...
8 years, 4 months ago (2012-08-23 14:40:22 UTC) #4
mkosiba (inactive)
New change is out. This only adds a DEPS file under chrome/android/java and removes the ...
8 years, 4 months ago (2012-08-23 15:03:14 UTC) #5
Torne
GYPs lgtm https://chromiumcodereview.appspot.com/10855171/diff/6001/android_webview/lib/DEPS File android_webview/lib/DEPS (right): https://chromiumcodereview.appspot.com/10855171/diff/6001/android_webview/lib/DEPS#newcode21 android_webview/lib/DEPS:21: "!chrome/browser/api/infobars/confirm_infobar_delegate.h", On 2012/08/23 14:27:46, Jói wrote: > ...
8 years, 4 months ago (2012-08-23 15:11:46 UTC) #6
Yaron
content/public/android lgtm https://chromiumcodereview.appspot.com/10855171/diff/6002/content/public/android/javatests/src/org/chromium/content/browser/test/CallbackHelper.java File content/public/android/javatests/src/org/chromium/content/browser/test/CallbackHelper.java (right): https://chromiumcodereview.appspot.com/10855171/diff/6002/content/public/android/javatests/src/org/chromium/content/browser/test/CallbackHelper.java#newcode30 content/public/android/javatests/src/org/chromium/content/browser/test/CallbackHelper.java:30: public synchronized int getCallCount() { Please use ...
8 years, 4 months ago (2012-08-23 15:52:54 UTC) #7
Jói
DEPS still LGTM
8 years, 4 months ago (2012-08-23 16:06:08 UTC) #8
Yaron
http://codereview.chromium.org/10855171/diff/13003/content/public/android/javatests/src/org/chromium/content/browser/test/CallbackHelper.java File content/public/android/javatests/src/org/chromium/content/browser/test/CallbackHelper.java (right): http://codereview.chromium.org/10855171/diff/13003/content/public/android/javatests/src/org/chromium/content/browser/test/CallbackHelper.java#newcode87 content/public/android/javatests/src/org/chromium/content/browser/test/CallbackHelper.java:87: public synchronized void notifyCalled() { This shouldn't be synchronized ...
8 years, 4 months ago (2012-08-23 17:06:01 UTC) #9
mkosiba (inactive)
8 years, 4 months ago (2012-08-23 19:05:52 UTC) #10
http://codereview.chromium.org/10855171/diff/13003/content/public/android/jav...
File
content/public/android/javatests/src/org/chromium/content/browser/test/CallbackHelper.java
(right):

http://codereview.chromium.org/10855171/diff/13003/content/public/android/jav...
content/public/android/javatests/src/org/chromium/content/browser/test/CallbackHelper.java:87:
public synchronized void notifyCalled() {
On 2012/08/23 17:06:01, Yaron wrote:
> This shouldn't be synchronized either. It should also use mLock

Done.

Powered by Google App Engine
This is Rietveld 408576698