utils/compiler/buildbot.py - Issue 10855169: Address additional review comments for annotated steps in r10644

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: utils/compiler/buildbot.py

Issue 10855169: Address additional review comments for annotated steps in r10644 (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: utils/compiler/buildbot.py

===================================================================

--- utils/compiler/buildbot.py (revision 10699)

+++ utils/compiler/buildbot.py (working copy)

@@ -305,10 +305,7 @@

return subprocess.call(cmd, env=NO_COLOR_ENV)

def GetShouldClobber():

- if os.environ.get(BUILDER_CLOBBER) == "1":

- return True

- else:

- return False

+ return os.environ.get(BUILDER_CLOBBER) == "1"

def main():

if len(sys.argv) == 0:

« no previous file with comments | « no previous file | no next file » | no next file with comments »