Issue 10855163: Revert 151586 - [net/dns] Resolve AF_UNSPEC on dual-stacked systems. Sort addresses according to RF…

Issue 10855163: Revert 151586 - [net/dns] Resolve AF_UNSPEC on dual-stacked systems. Sort addresses according to RF… (Closed)

Created:
8 years, 4 months ago by brettw

Modified:
8 years, 4 months ago

Reviewers:
szym

CC:
chromium-reviews, pam+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 151586 - [net/dns] Resolve AF_UNSPEC on dual-stacked systems. Sort addresses according to RFC3484. BUG=113993 TEST=./net_unittests --gtest_filter=AddressSorter*:HostResolverImplDnsTest.DnsTaskUnspec Review URL: https://chromiumcodereview.appspot.com/10442098 TBR=szym@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151603

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+105 lines, -1530 lines)			Patch
M	net/base/host_resolver_impl.h	View	1 chunk	+3 lines, -6 lines	0 comments	Download
M	net/base/host_resolver_impl.cc	View	7 chunks	+34 lines, -128 lines	0 comments	Download
M	net/base/host_resolver_impl_unittest.cc	View	3 chunks	+3 lines, -55 lines	0 comments	Download
MM	net/base/net_error_list.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
MM	net/base/net_util.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
MM	net/base/net_util.cc	View	2 chunks	+3 lines, -23 lines	0 comments	Download
MM	net/base/net_util_unittest.cc	View	1 chunk	+0 lines, -23 lines	0 comments	Download
D	net/dns/address_sorter.h	View	1 chunk	+0 lines, -46 lines	0 comments	Download
D	net/dns/address_sorter_posix.h	View	1 chunk	+0 lines, -94 lines	0 comments	Download
D	net/dns/address_sorter_posix.cc	View	1 chunk	+0 lines, -428 lines	0 comments	Download
D	net/dns/address_sorter_posix_unittest.cc	View	1 chunk	+0 lines, -325 lines	0 comments	Download
D	net/dns/address_sorter_unittest.cc	View	1 chunk	+0 lines, -49 lines	0 comments	Download
D	net/dns/address_sorter_win.cc	View	1 chunk	+0 lines, -197 lines	0 comments	Download
MM	net/dns/dns_client.h	View	2 chunks	+2 lines, -7 lines	0 comments	Download
MM	net/dns/dns_client.cc	View	3 chunks	+1 line, -9 lines	0 comments	Download
MM	net/dns/dns_response.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
MM	net/dns/dns_response.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
MM	net/dns/dns_response_unittest.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
MM	net/dns/dns_test_util.h	View	2 chunks	+1 line, -21 lines	0 comments	Download
MM	net/dns/dns_test_util.cc	View	7 chunks	+50 lines, -95 lines	0 comments	Download
MM	net/net.gyp	View	2 chunks	+0 lines, -6 lines	0 comments	Download
MM	net/tools/dns_fuzz_stub/dns_fuzz_stub.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

I think this broke the net unittests: http://build.chromium.org/p/chromium/builders/XP%20Tests%20%28dbg%29%282%29/builds/20166/steps/net_unittests/logs/stdio

8 years, 4 months ago (2012-08-14 23:33:18 UTC) #2

mmenke

8 years, 4 months ago (2012-08-15 00:07:09 UTC) #3

On 2012/08/14 23:33:18, brettw wrote:
> I think this broke the net unittests:
> 
>
http://build.chromium.org/p/chromium/builders/XP%2520Tests%2520%2528dbg%2529%...

Looks like it did, thanks.

Expand Messages | Collapse Messages