Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6989)

Unified Diff: chrome/test/functional/webrtc_brutality_test.py

Issue 10855161: Improve pyautolib errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Made the changes suggested by Nirnimesh. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/pyautolib/pyauto.py » ('j') | chrome/test/pyautolib/pyauto_errors.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/functional/webrtc_brutality_test.py
diff --git a/chrome/test/functional/webrtc_brutality_test.py b/chrome/test/functional/webrtc_brutality_test.py
index be115bcbbdf3bcd9a0a51cabf22461a888b85ce2..b095354cdf3aa11dc881bd7eb87998f0e6dcc5ce 100755
--- a/chrome/test/functional/webrtc_brutality_test.py
+++ b/chrome/test/functional/webrtc_brutality_test.py
@@ -57,18 +57,16 @@ class WebrtcBrutalityTest(webrtc_test_base.WebrtcTestBase):
url = self.GetFileURLForDataPath('webrtc', 'webrtc_jsep_test.html')
self.NavigateToURL(url)
- tab = self.GetBrowserWindow(0).GetTab(0)
self._GetUserMediaWithoutTakingAction(tab_index=0)
- tab.Close()
+ self.CloseTab()
def testSuccessfulGetUserMediaAndThenClose(self):
"""Waits for WebRTC to respond, and closes the tab."""
url = self.GetFileURLForDataPath('webrtc', 'webrtc_jsep_test.html')
self.NavigateToURL(url)
- tab = self.GetBrowserWindow(0).GetTab(0)
self.GetUserMedia(tab_index=0, action='allow')
- tab.Close()
+ self.CloseTab()
def _GetUserMediaWithoutTakingAction(self, tab_index):
self.assertEquals('ok-requested', self.ExecuteJavascript(
@@ -76,4 +74,4 @@ class WebrtcBrutalityTest(webrtc_test_base.WebrtcTestBase):
if __name__ == '__main__':
- pyauto_functional.Main()
+ pyauto_functional.Main()
« no previous file with comments | « no previous file | chrome/test/pyautolib/pyauto.py » ('j') | chrome/test/pyautolib/pyauto_errors.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698