Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10855161: Improve pyautolib errors. (Closed)

Created:
8 years, 4 months ago by craigdh
Modified:
8 years, 4 months ago
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh
Visibility:
Public.

Description

Improve pyautolib errors. Adds a new pyauto exception for failures caught by automation calls (inherits from JSONInterfaceError). Improves the error messages generated for automation infrastructure failures. TEST=Manually caused automation commands to fail and verified error messages. BUG=132803 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151853

Patch Set 1 #

Total comments: 6

Patch Set 2 : Made the changes suggested by Nirnimesh. #

Total comments: 1

Patch Set 3 : Fixed another usage of GetBrowserWindow #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -15 lines) Patch
M chrome/test/functional/tracing/tab_tracker.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/functional/webrtc_brutality_test.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/pyautolib/pyauto.py View 1 2 chunks +5 lines, -1 line 0 comments Download
M chrome/test/pyautolib/pyauto_errors.py View 1 2 1 chunk +9 lines, -1 line 0 comments Download
M chrome/test/pyautolib/pyautolib.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.cc View 3 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
craigdh
8 years, 4 months ago (2012-08-14 22:12:18 UTC) #1
Nirnimesh
https://chromiumcodereview.appspot.com/10855161/diff/1/chrome/test/pyautolib/pyauto.py File chrome/test/pyautolib/pyauto.py (right): https://chromiumcodereview.appspot.com/10855161/diff/1/chrome/test/pyautolib/pyauto.py#newcode89 chrome/test/pyautolib/pyauto.py:89: from pyauto_errors import AutomationCommandFail sort the list https://chromiumcodereview.appspot.com/10855161/diff/1/chrome/test/pyautolib/pyauto_errors.py File ...
8 years, 4 months ago (2012-08-15 00:11:21 UTC) #2
craigdh
https://chromiumcodereview.appspot.com/10855161/diff/1/chrome/test/pyautolib/pyauto.py File chrome/test/pyautolib/pyauto.py (right): https://chromiumcodereview.appspot.com/10855161/diff/1/chrome/test/pyautolib/pyauto.py#newcode89 chrome/test/pyautolib/pyauto.py:89: from pyauto_errors import AutomationCommandFail On 2012/08/15 00:11:21, Nirnimesh wrote: ...
8 years, 4 months ago (2012-08-15 00:50:58 UTC) #3
dennis_jeffrey
LGTM with a nit https://chromiumcodereview.appspot.com/10855161/diff/5001/chrome/test/pyautolib/pyauto_errors.py File chrome/test/pyautolib/pyauto_errors.py (right): https://chromiumcodereview.appspot.com/10855161/diff/5001/chrome/test/pyautolib/pyauto_errors.py#newcode13 chrome/test/pyautolib/pyauto_errors.py:13: """Represent an error in the ...
8 years, 4 months ago (2012-08-15 00:53:53 UTC) #4
Nirnimesh
I thought I also saw it used in tracing.py. Please check, and remove if present. ...
8 years, 4 months ago (2012-08-15 04:28:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/10855161/6004
8 years, 4 months ago (2012-08-15 16:29:28 UTC) #6
commit-bot: I haz the power
Failed to apply patch for chrome/test/functional/webrtc_brutality_test.py: While running patch -p1 --forward --force; patching file chrome/test/functional/webrtc_brutality_test.py ...
8 years, 4 months ago (2012-08-15 16:29:31 UTC) #7
craigdh
On 2012/08/15 16:29:31, I haz the power (commit-bot) wrote: > Failed to apply patch for ...
8 years, 4 months ago (2012-08-15 16:44:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/10855161/12002
8 years, 4 months ago (2012-08-15 16:44:29 UTC) #9
commit-bot: I haz the power
Try job failure for 10855161-12002 (retry) on win_rel for step "runhooks". It's a second try, ...
8 years, 4 months ago (2012-08-15 18:17:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/10855161/12002
8 years, 4 months ago (2012-08-15 18:21:37 UTC) #11
commit-bot: I haz the power
Try job failure for 10855161-12002 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-15 19:15:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/10855161/12002
8 years, 4 months ago (2012-08-15 22:12:35 UTC) #13
commit-bot: I haz the power
Try job failure for 10855161-12002 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-15 23:00:42 UTC) #14
craigdh
On 2012/08/15 23:00:42, I haz the power (commit-bot) wrote: > Try job failure for 10855161-12002 ...
8 years, 4 months ago (2012-08-15 23:05:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/10855161/12002
8 years, 4 months ago (2012-08-16 00:05:51 UTC) #16
commit-bot: I haz the power
Try job failure for 10855161-12002 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 4 months ago (2012-08-16 01:45:33 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/10855161/12002
8 years, 4 months ago (2012-08-16 01:48:39 UTC) #18
commit-bot: I haz the power
8 years, 4 months ago (2012-08-16 04:36:52 UTC) #19 
Change committed as 151853

Powered by Google App Engine
This is Rietveld 408576698