Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: chrome/browser/policy/user_policy_signin_service_unittest.cc

Issue 10855158: Fix valgrind-reported leak by creating an IO thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/policy/user_policy_signin_service_unittest.cc
diff --git a/chrome/browser/policy/user_policy_signin_service_unittest.cc b/chrome/browser/policy/user_policy_signin_service_unittest.cc
index 13e1e90b546ae5420c59cc8963fa80b3fa602c28..be9382f840a5a3ebd3ce35a7f336c077c07a28d3 100644
--- a/chrome/browser/policy/user_policy_signin_service_unittest.cc
+++ b/chrome/browser/policy/user_policy_signin_service_unittest.cc
@@ -38,7 +38,8 @@ class UserPolicySigninServiceTest : public testing::Test {
UserPolicySigninServiceTest()
: loop_(MessageLoop::TYPE_UI),
ui_thread_(content::BrowserThread::UI, &loop_),
- file_thread_(content::BrowserThread::FILE, &loop_) {}
+ file_thread_(content::BrowserThread::FILE, &loop_),
+ io_thread_(content::BrowserThread::IO, &loop_) {}
virtual void SetUp() OVERRIDE {
g_browser_process->browser_policy_connector()->Init();
@@ -84,11 +85,12 @@ class UserPolicySigninServiceTest : public testing::Test {
// UserCloudPolicyManager.
MockCloudPolicyStore* mock_store_;
- // BrowserPolicyConnector wants to initialize various components
- // asynchronously via tasks, so create a fake thread here.
+ // BrowserPolicyConnector and UrlFetcherFactory want to initialize and free
+ // various components asynchronously via tasks, so create fake threads here.
MessageLoop loop_;
content::TestBrowserThread ui_thread_;
content::TestBrowserThread file_thread_;
+ content::TestBrowserThread io_thread_;
scoped_ptr<TestingPrefService> local_state_;
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698