Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 10855158: Fix valgrind-reported leak by creating an IO thread. (Closed)

Created:
8 years, 4 months ago by Andrew T Wilson (Slow)
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix valgrind-reported leak by creating an IO thread. URLRequestContextGetter requires an IO thread to free itself, so create a fake thread. TBR=mnissler BUG=141123 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151671

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/policy/user_policy_signin_service_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Andrew T Wilson (Slow)
PTAL
8 years, 4 months ago (2012-08-14 20:06:53 UTC) #1
no longer working on chromium
On 2012/08/14 20:06:53, Andrew T Wilson wrote: > PTAL I will leave the review work ...
8 years, 4 months ago (2012-08-14 20:31:48 UTC) #2
Mattias Nissler (ping if slow)
LGTM assuming it fixes the leaks. Can you run a linux_chromeos_valgrind tryjob? Is there a ...
8 years, 4 months ago (2012-08-14 20:43:59 UTC) #3
Andrew T Wilson (Slow)
On 2012/08/14 20:43:59, Mattias Nissler wrote: > LGTM assuming it fixes the leaks. Can you ...
8 years, 4 months ago (2012-08-14 20:54:19 UTC) #4
Andrew T Wilson (Slow)
On 2012/08/14 20:54:19, Andrew T Wilson wrote: > On 2012/08/14 20:43:59, Mattias Nissler wrote: > ...
8 years, 4 months ago (2012-08-14 20:55:32 UTC) #5
Mattias Nissler (ping if slow)
On 2012/08/14 20:55:32, Andrew T Wilson wrote: > On 2012/08/14 20:54:19, Andrew T Wilson wrote: ...
8 years, 4 months ago (2012-08-14 21:07:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atwilson@chromium.org/10855158/1
8 years, 4 months ago (2012-08-15 03:26:49 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-15 06:53:20 UTC) #8
Change committed as 151671

Powered by Google App Engine
This is Rietveld 408576698