Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 10855149: Get rid of debug_flags.h includes from ui tests base class. Developers don't debug the few remainin… (Closed)

Created:
8 years, 4 months ago by jam
Modified:
8 years, 4 months ago
Reviewers:
Jói
CC:
chromium-reviews, robertshield, kkania
Visibility:
Public.

Description

Get rid of debug_flags.h includes from ui tests base class. Developers don't debug the few remaining tests so this isn't needed, and if they really want to pass these flags, they can use --extra-chrome-flags. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151499

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M chrome/test/DEPS View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/test/automation/proxy_launcher.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 4 months ago (2012-08-14 16:28:27 UTC) #1
Jói
8 years, 4 months ago (2012-08-14 16:29:57 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698