compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java - Issue 10855140: Issue 3562. Analyzer should not warn about shadowing

Unified Diff: compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java

Issue 10855140: Issue 3562. Analyzer should not warn about shadowing (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java ('k') | compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java

diff --git a/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java b/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java

index 56c5eba8b3e87d36b3243465161aa8e6cf031581..2453c1fa746fd5e850dc134bc9b1d3dd670dcb23 100644

--- a/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java

+++ b/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java

@@ -399,8 +399,6 @@ public class IncrementalCompilation2Test extends CompilerTestCase {

didWrite("B.dart", EXTENSION_TIMESTAMP);

// But application should be build.

assertAppBuilt();

- // Because B was compiled, it has warning.

- assertErrors(errors, errEx(ResolverErrorCode.DUPLICATE_LOCAL_VARIABLE_WARNING, 3, 7, 20));

}

public void test_undeclareTopLevel_conflictWithLocalVariable() {

@@ -417,7 +415,6 @@ public class IncrementalCompilation2Test extends CompilerTestCase {

" var duplicate;",

"}"));

compile();

- assertErrors(errors, errEx(ResolverErrorCode.DUPLICATE_LOCAL_VARIABLE_WARNING, 3, 7, 9));

// Update units and compile.

appSource.setContent("A.dart", "");

compile();

@@ -427,8 +424,6 @@ public class IncrementalCompilation2Test extends CompilerTestCase {

didWrite("B.dart", EXTENSION_TIMESTAMP);

// ... but application should be rebuild.

assertAppBuilt();

- // Because B was recompiled, it has no warning.

- assertErrors(errors);

}

/**

@@ -448,7 +443,6 @@ public class IncrementalCompilation2Test extends CompilerTestCase {

" var duplicate;",

"}"));

compile();

- assertErrors(errors, errEx(ResolverErrorCode.DUPLICATE_LOCAL_VARIABLE_WARNING, 3, 7, 9));

// Exclude A and compile.

appSource.setContent(

APP,

@@ -464,8 +458,6 @@ public class IncrementalCompilation2Test extends CompilerTestCase {

didWrite("B.dart", EXTENSION_TIMESTAMP);

// ... but application should be rebuild.

didWrite(APP, EXTENSION_DEPS);

- // Because B was recompiled, it has no warning.

- assertErrors(errors);

}

public void test_declareField_conflictWithLocalVariable() {

@@ -501,8 +493,6 @@ public class IncrementalCompilation2Test extends CompilerTestCase {

// B depends on A class, so compiled.

didWrite("B.dart", EXTENSION_TIMESTAMP);

assertAppBuilt();

- // Because B was compiled, it has warning.

- assertErrors(errors, errEx(ResolverErrorCode.DUPLICATE_LOCAL_VARIABLE_WARNING, 4, 9, 3));

}

public void test_declareTopLevelVariable_conflictOtherTopLevelVariable() {