Issue 3562. Analyzer should not warn about shadowing

editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/index/AnalysisMarkerManager.java

Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/index/AnalysisMarkerManager.java
diff --git a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/index/AnalysisMarkerManager.java b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/index/AnalysisMarkerManager.java
index 5bfaee21208122a117c048b924b5494a5011fb0c..0ea6bb59d26d577bb3a91b7c6102399492407d63 100644
--- a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/index/AnalysisMarkerManager.java
+++ b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/index/AnalysisMarkerManager.java
@@ -17,9 +17,7 @@ import com.google.dart.compiler.DartCompilationError;
 import com.google.dart.compiler.ErrorCode;
 import com.google.dart.compiler.ErrorSeverity;
 import com.google.dart.compiler.SubSystem;
-import com.google.dart.compiler.resolver.ResolverErrorCode;
 import com.google.dart.tools.core.DartCore;
-import com.google.dart.tools.core.DartCoreDebug;
 import com.google.dart.tools.core.analysis.AnalysisError;
 import com.google.dart.tools.core.analysis.AnalysisEvent;
 import com.google.dart.tools.core.analysis.AnalysisListener;
@@ -58,10 +56,6 @@ class AnalysisMarkerManager implements AnalysisListener {
      * Create an error marker for the specified file
      */
     void createMarker(File file, DartCompilationError error) {
-      if (DartCoreDebug.HIDE_SHADOW_WARNINGS && isShadowWarning(error)) {
-        return;
-      }
-
       if (file == null || error == null) {
         return;
       }
@@ -155,18 +149,6 @@ class AnalysisMarkerManager implements AnalysisListener {
   }
 
   /**
-   * @return if given {@link DartCompilationError} is warning that some element shadows other
-   *         element.
-   */
-  private static boolean isShadowWarning(DartCompilationError error) {
-    ErrorCode errorCode = error.getErrorCode();
-    return errorCode == ResolverErrorCode.DUPLICATE_FUNCTION_EXPRESSION_WARNING
-        || errorCode == ResolverErrorCode.DUPLICATE_LOCAL_VARIABLE_WARNING
-        || errorCode == ResolverErrorCode.DUPLICATE_PARAMETER_WARNING
-        || errorCode == ResolverErrorCode.DUPLICATE_TYPE_VARIABLE_WARNING;
-  }
-
-  /**
    * A collection of marker changes to be made. Synchronize against this field before accessing.
    */
   private final ArrayList<MarkerOp> queue;