Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2091)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 10855134: In checked mode, make sure the ssa compiler propagates the checked types of (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_optimizer.cc » ('j') | runtime/vm/flow_graph_optimizer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
===================================================================
--- runtime/vm/flow_graph_builder.cc (revision 10604)
+++ runtime/vm/flow_graph_builder.cc (working copy)
@@ -28,6 +28,7 @@
DEFINE_FLAG(bool, trace_type_check_elimination, false,
"Trace type check elimination at compile time.");
DECLARE_FLAG(bool, enable_type_checks);
+DECLARE_FLAG(bool, use_ssa);
FlowGraphBuilder::FlowGraphBuilder(const ParsedFunction& parsed_function)
@@ -2195,11 +2196,22 @@
NULL,
parameter.type(),
parameter.name())) {
- Value* load = Bind(BuildLoadLocal(parameter));
- Do(BuildAssertAssignable(parameter.token_pos(),
- load,
- parameter.type(),
- parameter.name()));
+ Value* parameter_value = Bind(BuildLoadLocal(parameter));
+ AssertAssignableComp* assert_assignable =
+ BuildAssertAssignable(parameter.token_pos(),
+ parameter_value,
+ parameter.type(),
+ parameter.name());
+ if (FLAG_use_ssa) {
+ parameter_value = Bind(assert_assignable);
+ // Store the type checked argument back to its corresponding local
+ // variable so that ssa renaming detects the dependency and makes use
+ // of the checked type in type propagation.
+ Do(BuildStoreLocal(parameter, parameter_value));
+ } else {
+ // No need to store the check parameter value back when not using ssa.
+ Do(assert_assignable);
+ }
}
pos++;
}
« no previous file with comments | « no previous file | runtime/vm/flow_graph_optimizer.cc » ('j') | runtime/vm/flow_graph_optimizer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698