Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 10855131: Remove Stale Isolate Entries (Closed)

Created:
8 years, 4 months ago by csharp
Modified:
8 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove Stale Isolate Entries Just a quick fix to get the linux swarm machine able to compile again. NOTRY=true BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151466

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M chrome/browser_tests.isolate View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/unit_tests.isolate View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
csharp
8 years, 4 months ago (2012-08-13 20:43:58 UTC) #1
Nico
How did you create this? Maruel always runs some script to create these patches automatically ...
8 years, 4 months ago (2012-08-13 20:45:15 UTC) #2
csharp
On 2012/08/13 20:45:15, Nico wrote: > How did you create this? Maruel always runs some ...
8 years, 4 months ago (2012-08-13 20:52:47 UTC) #3
Nico
Can you provide a link to the broken machine?
8 years, 4 months ago (2012-08-13 20:55:46 UTC) #4
csharp
On 2012/08/13 20:55:46, Nico wrote: > Can you provide a link to the broken machine? ...
8 years, 4 months ago (2012-08-13 20:58:12 UTC) #5
Nico
lgtm thanks. We don't use that bot for anything yet, right? So fixing them isn't ...
8 years, 4 months ago (2012-08-13 21:23:14 UTC) #6
csharp
On 2012/08/13 21:23:14, Nico wrote: > lgtm > > thanks. We don't use that bot ...
8 years, 4 months ago (2012-08-14 12:49:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/10855131/1
8 years, 4 months ago (2012-08-14 12:49:56 UTC) #8
commit-bot: I haz the power
Change committed as 151466
8 years, 4 months ago (2012-08-14 12:50:17 UTC) #9
M-A Ruel
8 years, 4 months ago (2012-08-20 19:51:49 UTC) #10
On 2012/08/13 20:52:47, csharp wrote:
> On 2012/08/13 20:45:15, Nico wrote:
> > How did you create this? Maruel always runs some script to create these
> patches
> > automatically (I don't know which script though).
> 
> This was just done by building locally and removing the missing dependencies
by
> hand. I'm looking into the script stuff a bit right now but I'm not sure how
to
> them correctly right now. 
> 
> This change just is focused on getting the machines to compile without
worrying
> about what files are still missing.

If you "git log -- any.isolate" file, you see "autogenerated with" comments with
the explicit commands used to generate the CL.

To remove files, contrary to adding files, a manual intervention is required at
the moment.

Thanks

Powered by Google App Engine
This is Rietveld 408576698