Issue 10855123: Remove unnecessary assignment in transport_client_socket_unittest.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10855123: Remove unnecessary assignment in transport_client_socket_unittest.cc. (Closed)

Created:
8 years, 4 months ago by Philippe

Modified:
8 years, 4 months ago

Reviewers:
mmenke

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove unnecessary assignment in transport_client_socket_unittest.cc. This is part of Chrome for Android upstreaming. This line was introduced by r137387 which turned |sock| into a scoped_refptr rather than a raw pointer (that needed to be initialized). This assignment is obviously not needed anymore. Internally we don't have this extra '= NULL' which causes an unnecessary diff. BUG=136750 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151276

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	net/socket/transport_client_socket_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/10855123/1

8 years, 4 months ago (2012-08-13 14:44:10 UTC) #3

Change committed as 151276

Expand Messages | Collapse Messages