Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: chrome/common/extensions/csp_validator.cc

Issue 10855122: Whitelisting `127.0.0.1` and `localhost` for HTTP in extensions' CSP. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Second pass. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/common/extensions/csp_validator_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/csp_validator.h" 5 #include "chrome/common/extensions/csp_validator.h"
6 6
7 #include "base/string_split.h" 7 #include "base/string_split.h"
8 #include "base/string_tokenizer.h" 8 #include "base/string_tokenizer.h"
9 #include "base/string_util.h" 9 #include "base/string_util.h"
10 10
(...skipping 28 matching lines...) Expand all
39 while (tokenizer.GetNext()) { 39 while (tokenizer.GetNext()) {
40 std::string source = tokenizer.token(); 40 std::string source = tokenizer.token();
41 StringToLowerASCII(&source); 41 StringToLowerASCII(&source);
42 42
43 if (EndsWith(source, "*", true)) 43 if (EndsWith(source, "*", true))
44 return false; 44 return false;
45 45
46 // We might need to relax this whitelist over time. 46 // We might need to relax this whitelist over time.
47 if (source == "'self'" || 47 if (source == "'self'" ||
48 source == "'none'" || 48 source == "'none'" ||
49 source == "http://127.0.0.1" ||
50 LowerCaseEqualsASCII(source, "http://localhost") ||
51 StartsWithASCII(source, "http://127.0.0.1:", false) ||
52 StartsWithASCII(source, "http://localhost:", false) ||
49 StartsWithASCII(source, "https://", true) || 53 StartsWithASCII(source, "https://", true) ||
50 StartsWithASCII(source, "chrome://", true) || 54 StartsWithASCII(source, "chrome://", true) ||
51 StartsWithASCII(source, "chrome-extension://", true) || 55 StartsWithASCII(source, "chrome-extension://", true) ||
52 StartsWithASCII(source, "chrome-extension-resource:", true)) { 56 StartsWithASCII(source, "chrome-extension-resource:", true)) {
53 continue; 57 continue;
54 } 58 }
55 59
56 return false; 60 return false;
57 } 61 }
58 62
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 } 166 }
163 } 167 }
164 } 168 }
165 169
166 return seen_sandbox; 170 return seen_sandbox;
167 } 171 }
168 172
169 } // csp_validator 173 } // csp_validator
170 174
171 } // extensions 175 } // extensions
OLDNEW
« no previous file with comments | « no previous file | chrome/common/extensions/csp_validator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698