views: Put 'with_content' in views_examples targets.

views: Put 'with_content' in views_examples targets.

This is so it's clear that they depend on content module. In a follow up
patch we will have views_examples_lib and views_examples_exe targets that
does not depend in content/ module to build.

BUG=141187
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151408

[Ben Goodger (Google), 2012-08-13 15:29:59]

lgtm


On Sun, Aug 12, 2012 at 6:58 PM, <tfarina@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> views: Put 'with_content' in views_examples targets.
>
> This is so it's clear that they depend on content module. In a follow up
> patch we will have views_examples_lib and views_examples_exe targets that
> does not depend in content/ module to build.
>
> BUG=141187
> R=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/10855119/<http://codereview.chromium.org/108...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M ash/ash.gyp
>   M ui/views/views.gyp
>
>
> Index: ash/ash.gyp
> diff --git a/ash/ash.gyp b/ash/ash.gyp
> index 7c343d3b09be1e829350f6d9479be5**5943e87214..**
> 36764d9222b7bbcf26fc79d9c97f84**29e6a293a6 100644
> --- a/ash/ash.gyp
> +++ b/ash/ash.gyp
> @@ -403,7 +403,7 @@
>          '../ui/ui.gyp:ui_resources',
>          '../ui/ui.gyp:ui_test_support'**,
>          '../ui/views/views.gyp:views',
> -        '../ui/views/views.gyp:views_**examples_lib',
> +        '../ui/views/views.gyp:views_**examples_with_content_lib',
>          '../ui/views/views.gyp:test_**support_views',
>          'ash',
>        ],
> @@ -539,7 +539,7 @@
>          '../ui/ui.gyp:ui',
>          '../ui/ui.gyp:ui_resources',
>          '../ui/views/views.gyp:views',
> -        '../ui/views/views.gyp:views_**examples_lib',
> +        '../ui/views/views.gyp:views_**examples_with_content_lib',
>          '../ui/views/views.gyp:test_**support_views',
>          'ash',
>        ],
> Index: ui/views/views.gyp
> diff --git a/ui/views/views.gyp b/ui/views/views.gyp
> index 1c70e74b979b6f927549138e97e23f**f759d52831..**
> cbe2bf9b8c078c7ed46d8b3464f1d6**c496cce39f 100644
> --- a/ui/views/views.gyp
> +++ b/ui/views/views.gyp
> @@ -589,7 +589,7 @@
>        ],
>      },  # target_name: views_unittests
>      {
> -      'target_name': 'views_examples_lib',
> +      'target_name': 'views_examples_with_content_**lib',
>        'type': 'static_library',
>        'dependencies': [
>          '../../base/base.gyp:base',
> @@ -669,9 +669,9 @@
>            ],
>          }],
>        ],
> -    },  # target_name: views_examples_lib
> +    },  # target_name: views_examples_with_content_**lib
>      {
> -      'target_name': 'views_examples_exe',
> +      'target_name': 'views_examples_with_content_**exe',
>        'type': 'executable',
>        'dependencies': [
>          '../../base/base.gyp:base',
> @@ -685,7 +685,7 @@
>          '../../third_party/icu/icu.**gyp:icuuc',
>          '../ui.gyp:ui',
>          '../ui.gyp:ui_resources',
> -        'views_examples_lib',
> +        'views_examples_with_content_**lib',
>        ],
>        'include_dirs': [
>          '../..',
> @@ -736,6 +736,6 @@
>            ],
>          }],
>        ],
> -    },  # target_name: views_examples_lib
> +    },  # target_name: views_examples_with_content_**exe
>    ],
>  }
>
>
>