Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Side by Side Diff: chrome/browser/extensions/crx_installer_browsertest.cc

Issue 10855116: Move DownloadTestObserver and friends down into content. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Incorporated comments. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/download/download_crx_util.h" 5 #include "chrome/browser/download/download_crx_util.h"
6 #include "chrome/browser/download/download_service.h" 6 #include "chrome/browser/download/download_service.h"
7 #include "chrome/browser/download/download_service_factory.h" 7 #include "chrome/browser/download/download_service_factory.h"
8 #include "chrome/browser/download/download_test_observer.h"
9 #include "chrome/browser/extensions/crx_installer.h" 8 #include "chrome/browser/extensions/crx_installer.h"
10 #include "chrome/browser/extensions/extension_browsertest.h" 9 #include "chrome/browser/extensions/extension_browsertest.h"
11 #include "chrome/browser/extensions/extension_install_prompt.h" 10 #include "chrome/browser/extensions/extension_install_prompt.h"
12 #include "chrome/browser/extensions/extension_service.h" 11 #include "chrome/browser/extensions/extension_service.h"
13 #include "chrome/browser/profiles/profile.h" 12 #include "chrome/browser/profiles/profile.h"
14 #include "chrome/browser/ui/browser.h" 13 #include "chrome/browser/ui/browser.h"
15 #include "chrome/browser/ui/browser_window.h" 14 #include "chrome/browser/ui/browser_window.h"
16 #include "chrome/common/chrome_switches.h" 15 #include "chrome/common/chrome_switches.h"
17 #include "chrome/common/extensions/extension.h" 16 #include "chrome/common/extensions/extension.h"
18 #include "chrome/common/extensions/extension_file_util.h" 17 #include "chrome/common/extensions/extension_file_util.h"
19 #include "chrome/common/extensions/extension_switch_utils.h" 18 #include "chrome/common/extensions/extension_switch_utils.h"
20 #include "chrome/common/extensions/permissions/permission_set.h" 19 #include "chrome/common/extensions/permissions/permission_set.h"
21 #include "chrome/test/base/ui_test_utils.h" 20 #include "chrome/test/base/ui_test_utils.h"
21 #include "content/public/test/download_test_observer.h"
22 #include "grit/generated_resources.h" 22 #include "grit/generated_resources.h"
23 #include "ui/base/l10n/l10n_util.h" 23 #include "ui/base/l10n/l10n_util.h"
24 24
25 class SkBitmap; 25 class SkBitmap;
26 26
27 namespace extensions { 27 namespace extensions {
28 28
29 namespace { 29 namespace {
30 30
31 // Observer waits for exactly one download to finish. 31 // Observer waits for exactly one download to finish.
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 202
203 MockInstallPrompt* mock_prompt = 203 MockInstallPrompt* mock_prompt =
204 CreateMockInstallPromptForBrowser(browser()); 204 CreateMockInstallPromptForBrowser(browser());
205 download_crx_util::SetMockInstallPromptForTesting(mock_prompt); 205 download_crx_util::SetMockInstallPromptForTesting(mock_prompt);
206 206
207 LOG(ERROR) << "PackAndInstallExtension: Getting download manager"; 207 LOG(ERROR) << "PackAndInstallExtension: Getting download manager";
208 content::DownloadManager* download_manager = 208 content::DownloadManager* download_manager =
209 content::BrowserContext::GetDownloadManager(browser()->profile()); 209 content::BrowserContext::GetDownloadManager(browser()->profile());
210 210
211 LOG(ERROR) << "PackAndInstallExtension: Setting observer"; 211 LOG(ERROR) << "PackAndInstallExtension: Setting observer";
212 scoped_ptr<DownloadTestObserver> observer( 212 scoped_ptr<content::DownloadTestObserver> observer(
213 new DownloadTestObserverTerminal( 213 new content::DownloadTestObserverTerminal(
214 download_manager, kNumDownloadsExpected, 214 download_manager, kNumDownloadsExpected,
215 DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_ACCEPT)); 215 content::DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_ACCEPT));
216 LOG(ERROR) << "PackAndInstallExtension: Navigating to URL"; 216 LOG(ERROR) << "PackAndInstallExtension: Navigating to URL";
217 ui_test_utils::NavigateToURLWithDisposition(browser(), url, CURRENT_TAB, 217 ui_test_utils::NavigateToURLWithDisposition(browser(), url, CURRENT_TAB,
218 ui_test_utils::BROWSER_TEST_NONE); 218 ui_test_utils::BROWSER_TEST_NONE);
219 219
220 EXPECT_TRUE(WaitForCrxInstallerDone()); 220 EXPECT_TRUE(WaitForCrxInstallerDone());
221 LOG(ERROR) << "PackAndInstallExtension: Extension install"; 221 LOG(ERROR) << "PackAndInstallExtension: Extension install";
222 EXPECT_TRUE(mock_prompt->confirmation_requested()); 222 EXPECT_TRUE(mock_prompt->confirmation_requested());
223 LOG(ERROR) << "PackAndInstallExtension: Extension install confirmed"; 223 LOG(ERROR) << "PackAndInstallExtension: Extension install confirmed";
224 } 224 }
225 225
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
267 EXPECT_EQ(string16(), mock_prompt->error()) << kTestData[i]; 267 EXPECT_EQ(string16(), mock_prompt->error()) << kTestData[i];
268 } else { 268 } else {
269 EXPECT_EQ(l10n_util::GetStringUTF16( 269 EXPECT_EQ(l10n_util::GetStringUTF16(
270 IDS_EXTENSION_INSTALL_DISALLOWED_ON_SITE), 270 IDS_EXTENSION_INSTALL_DISALLOWED_ON_SITE),
271 mock_prompt->error()) << kTestData[i]; 271 mock_prompt->error()) << kTestData[i];
272 } 272 }
273 } 273 }
274 } 274 }
275 275
276 } // namespace extensions 276 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/downloads/downloads_api_unittest.cc ('k') | chrome/browser/ui/browser_close_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698