Show extension settings for extension notifications

Show extension settings for extension notifications

This also:
* Sends notification removal requests instead of directly removing notifications for removal by source
* Fixes a bug where clicking on a menu item outside the bubble would close the buble and not trigger the menu event

BUG=139697
For chrome/browser/ui/views/ash/balloon_collection_impl_ash.cc:
TBR=sky@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151518

[sadrul, 2012-08-13 22:09:08]

http://codereview.chromium.org/10855113/diff/1/ash/system/web_notification/we...
File ash/system/web_notification/web_notification_tray.cc (right):

http://codereview.chromium.org/10855113/diff/1/ash/system/web_notification/we...
ash/system/web_notification/web_notification_tray.cc:460:
tray_->set_menu_open(true);
This feels like a hack. The app-list controller does this slightly differently:
if a click happens in the menu-container window, then the click doesn't close
the bubble (https://chromiumcodereview.appspot.com/10831024/). Perhaps we can do
the same in TrayBubbleView::Host::ProcessLocatedEvent?

[stevenjb, 2012-08-14 00:48:37]

http://codereview.chromium.org/10855113/diff/1/ash/system/web_notification/we...
File ash/system/web_notification/web_notification_tray.cc (right):

http://codereview.chromium.org/10855113/diff/1/ash/system/web_notification/we...
ash/system/web_notification/web_notification_tray.cc:460:
tray_->set_menu_open(true);
On 2012/08/13 22:09:08, sadrul wrote:
> This feels like a hack. The app-list controller does this slightly
differently:
> if a click happens in the menu-container window, then the click doesn't close
> the bubble (https://chromiumcodereview.appspot.com/10831024/). Perhaps we can
do
> the same in TrayBubbleView::Host::ProcessLocatedEvent?

Sure. I'm not a huge fan of using globals, but at least it has the advantage
that it will work in the system tray if we add any menus to it.
Done.

[sadrul, 2012-08-14 01:49:51]

LGTM. Thanks

[commit-bot: I haz the power, 2012-08-14 03:28:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10855113/11001

[commit-bot: I haz the power, 2012-08-14 03:28:07]

Presubmit check for 10855113-11001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui/views/ash

Presubmit checks took 1.0s to calculate.

[commit-bot: I haz the power, 2012-08-14 03:34:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10855113/11001

[commit-bot: I haz the power, 2012-08-14 06:05:28]

Try job failure for 10855113-11001 (retry) on win_rel for step "browser_tests".
It's a second try, previously, steps "interactive_ui_tests, browser_tests"
failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-08-14 16:08:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10855113/11001

[commit-bot: I haz the power, 2012-08-14 18:28:16]

Change committed as 151518