Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 10855106: Add high dpi folder icons. (Closed)

Created:
8 years, 4 months ago by flackr
Modified:
8 years, 4 months ago
Reviewers:
oshima, James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews), oshima+watch_chromium.org
Visibility:
Public.

Description

Add high dpi folder icons. BUG=129203 TEST=Run chrome with --force-device-scale-factor=2 and go to bookmark manager, folder icons are high dpi. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151258

Patch Set 1 #

Patch Set 2 : Move folder icons to common directory. #

Patch Set 3 : Merge with master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M chrome/browser/resources/bookmark_manager/css/bmm.css View 1 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/resources/shared/css/tree.css View 1 2 chunks +12 lines, -8 lines 0 comments Download
A + ui/resources/default_100_percent/common/folder_closed.png View 1 Binary file 0 comments Download
A + ui/resources/default_100_percent/common/folder_closed_rtl.png View 1 Binary file 0 comments Download
A + ui/resources/default_100_percent/common/folder_open.png View 1 Binary file 0 comments Download
A + ui/resources/default_100_percent/common/folder_open_rtl.png View 1 Binary file 0 comments Download
D ui/resources/default_100_percent/folder_closed.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D ui/resources/default_100_percent/folder_closed_rtl.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D ui/resources/default_100_percent/folder_open.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D ui/resources/default_100_percent/folder_open_rtl.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/folder_closed.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/folder_closed_rtl.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/folder_open.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/folder_open_rtl.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/ui_resources.grd View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
flackr
PTAL, thanks!
8 years, 4 months ago (2012-08-10 17:45:41 UTC) #1
oshima
On 2012/08/10 17:45:41, flackr wrote: > PTAL, thanks! shouldn't they be in common directory?
8 years, 4 months ago (2012-08-10 20:00:16 UTC) #2
flackr
On 2012/08/10 20:00:16, oshima wrote: > On 2012/08/10 17:45:41, flackr wrote: > > PTAL, thanks! ...
8 years, 4 months ago (2012-08-10 23:13:24 UTC) #3
flackr
On 2012/08/10 23:13:24, flackr wrote: > On 2012/08/10 20:00:16, oshima wrote: > > On 2012/08/10 ...
8 years, 4 months ago (2012-08-11 04:48:12 UTC) #4
oshima
lgtm On Aug 11, 2012 1:48 PM, <flackr@chromium.org> wrote: > On 2012/08/10 23:13:24, flackr wrote: ...
8 years, 4 months ago (2012-08-11 08:21:06 UTC) #5
James Hawkins
8 years, 4 months ago (2012-08-11 16:32:14 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698