Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 10855105: Unbreak ppapi_example_video_decode for platforms that don't have ARB extensions. (Closed)

Created:
8 years, 4 months ago by Ami GONE FROM CHROMIUM
Modified:
8 years, 4 months ago
Reviewers:
sail
CC:
chromium-reviews, Pawel Osciak, ArunM
Visibility:
Public.

Description

Unbreak ppapi_example_video_decode for platforms that don't have ARB extensions. (originally broken by r141977) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151109

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -28 lines) Patch
M ppapi/examples/video_decode/video_decode.cc View 1 5 chunks +39 lines, -28 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Ami GONE FROM CHROMIUM
sail: please review. posciak: FYI. arun: this is should make the example work for you ...
8 years, 4 months ago (2012-08-10 16:52:27 UTC) #1
sail
Argh, sorry for breaking this. LGTM https://chromiumcodereview.appspot.com/10855105/diff/1/ppapi/examples/video_decode/video_decode.cc File ppapi/examples/video_decode/video_decode.cc (right): https://chromiumcodereview.appspot.com/10855105/diff/1/ppapi/examples/video_decode/video_decode.cc#newcode139 ppapi/examples/video_decode/video_decode.cc:139: void CreateARBProgramOnce(); I ...
8 years, 4 months ago (2012-08-10 17:45:44 UTC) #2
Ami GONE FROM CHROMIUM
https://chromiumcodereview.appspot.com/10855105/diff/1/ppapi/examples/video_decode/video_decode.cc File ppapi/examples/video_decode/video_decode.cc (right): https://chromiumcodereview.appspot.com/10855105/diff/1/ppapi/examples/video_decode/video_decode.cc#newcode139 ppapi/examples/video_decode/video_decode.cc:139: void CreateARBProgramOnce(); On 2012/08/10 17:45:45, sail wrote: > I ...
8 years, 4 months ago (2012-08-10 17:56:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/10855105/4001
8 years, 4 months ago (2012-08-10 17:57:35 UTC) #4
commit-bot: I haz the power
Try job failure for 10855105-4001 on linux_clang for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clang&number=41073 Step "update" is always ...
8 years, 4 months ago (2012-08-10 18:03:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/10855105/4001
8 years, 4 months ago (2012-08-10 18:19:21 UTC) #6
commit-bot: I haz the power
Try job failure for 10855105-4001 on linux_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=46653 Step "update" is always ...
8 years, 4 months ago (2012-08-10 18:27:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/10855105/4001
8 years, 4 months ago (2012-08-10 18:31:02 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-08-10 18:43:06 UTC) #9
Try job failure for 10855105-4001 on linux_chromeos for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Powered by Google App Engine
This is Rietveld 408576698