RemoveFromGraph on definitions asserts empty use lists.

runtime/vm/intermediate_language.cc

Index: runtime/vm/intermediate_language.cc
diff --git a/runtime/vm/intermediate_language.cc b/runtime/vm/intermediate_language.cc
index 060487bf9e6325f8f7cc7716392c5f298daffc8d..215f7db07e1c6f699a6b7d04c7d24b98d4e04f4c 100644
--- a/runtime/vm/intermediate_language.cc
+++ b/runtime/vm/intermediate_language.cc
@@ -142,6 +142,12 @@ Instruction* Instruction::RemoveFromGraph(bool return_previous) {
 }
 
 
+Instruction* Definition::RemoveFromGraph(bool return_previous) {
+  ASSERT(use_list() == NULL);

[Florian Schneider, 2012/08/13 08:37:37]

Alternatively, you could put the assert in Instruction::RemoveFromGraph to avoid
overriding just for the assertion:

ASSERT(AsDefinition() == NULL || AsDefinition()->use_list() == NULL);

+  return Instruction::RemoveFromGraph(return_previous);
+}
+
+
 void ForwardInstructionIterator::RemoveCurrentFromGraph() {
   current_ = current_->RemoveFromGraph(true);  // Set current_ to previous.
 }