src/ia32/lithium-codegen-ia32.cc - Issue 10855098: Deoptimization support for accessors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-codegen-ia32.cc

Issue 10855098: Deoptimization support for accessors. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Tiny test changes. Rebased. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/lithium-codegen-ia32.cc

diff --git a/src/ia32/lithium-codegen-ia32.cc b/src/ia32/lithium-codegen-ia32.cc

index 829bda0fb14defac56fed1163bac004c365b1c51..b9783d079a4ef169997103c6977131c2faa6001c 100644

--- a/src/ia32/lithium-codegen-ia32.cc

+++ b/src/ia32/lithium-codegen-ia32.cc

@@ -433,7 +433,9 @@ void LCodeGen::WriteTranslation(LEnvironment* environment,

translation->BeginConstructStubFrame(closure_id, translation_size);

break;

case JS_SETTER:

- // TODO(svenpanne) Implement me!

+ ASSERT(translation_size == 2);

+ ASSERT(height == 0);

+ translation->BeginSetterStubFrame(closure_id);

break;

case ARGUMENTS_ADAPTOR:

translation->BeginArgumentsAdaptorFrame(closure_id, translation_size);

« no previous file with comments | « src/ia32/deoptimizer-ia32.cc ('k') | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »