Deoptimization support for accessors.

src/objects.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 8285 matching lines @@
             Object* function = LiteralArray()->get(function_id);
             JSFunction::cast(function)->PrintName(out);
           } else {
             PrintF(out, "<self>");
           }
           PrintF(out, ", height=%u}", height);
           break;
         }
 
         case Translation::ARGUMENTS_ADAPTOR_FRAME:
-        case Translation::CONSTRUCT_STUB_FRAME: {
+        case Translation::CONSTRUCT_STUB_FRAME:
+        case Translation::SETTER_STUB_FRAME: {

[Michael Starzinger, 2012/08/16 17:20:04]

Can we make that an own case that doesn't print the height at all? This makes it
hard to see when we expect the iterator to give us a height and when not.

[Sven Panne, 2012/08/17 07:27:26]

Done.

           int function_id = iterator.Next();
           JSFunction* function =
               JSFunction::cast(LiteralArray()->get(function_id));
-          unsigned height = iterator.Next();
+          unsigned height =
+              opcode == Translation::SETTER_STUB_FRAME ? 2 : iterator.Next();

[Michael Starzinger, 2012/08/16 17:20:04]

Actually, height = 0 for the setter stub, but that doesn't matter if the above
comment is addressed.

[Sven Panne, 2012/08/17 07:27:26]

Well, it is totally unclear what is *really* meant here: There is a lot of
naming confusion going on, this "height" here is sometimes called
"translation_size", at other places "height" has a different meaning, compare
e.g. LCodeGen::WriteTranslation and Translation::BeginConstructStubFrame. But as
you said, this won't matter here. :-)

           PrintF(out, "{function=");
           function->PrintName(out);
           PrintF(out, ", height=%u}", height);
           break;
         }
 
         case Translation::DUPLICATE:
           break;
 
         case Translation::REGISTER: {
@@ skipping 4834 matching lines @@
   set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER);
   set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER);
   set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER);
   set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER);
   set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER);
   set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER);
   set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER);
 }
 
 } }  // namespace v8::internal