extensions: Fix crash on empty extension action icons

extensions: Fix crash on empty extension action icons

BUG=141386
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150962

[Nico, 2012-08-10 00:03:34]

Since you were able to regress this without any test noticing, you might want to
consider adding some test coverage for this code.

[Jeffrey Yasskin, 2012-08-10 00:12:28]

LGTM

Yes @ the need for more testing. I think this also made setIcon(path) fail to
work entirely, beyond crashing the linux port. I'll see what I can put together.

[commit-bot: I haz the power, 2012-08-10 00:19:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/10855090/6002

[Nico, 2012-08-10 00:24:22]

On 2012/08/10 00:12:28, Jeffrey Yasskin wrote:
> LGTM

Thanks!

> I think this also made setIcon(path) fail to work entirely, beyond crashing
the linux port

Your CL landed before the m22 branch. Did the fix for setIcon() not working at
all make it in before the m22 branch too? Is there a bug for that? Does your fix
need to be merged? (omahaproxy.appspot.com has branch revision numbers)

[Jeffrey Yasskin, 2012-08-10 00:26:25]

On Thu, Aug 9, 2012 at 5:24 PM,  <thakis@chromium.org> wrote:
> On 2012/08/10 00:12:28, Jeffrey Yasskin wrote:
>>
>> LGTM
>
>
> Thanks!
>
>
>> I think this also made setIcon(path) fail to work entirely, beyond
>> crashing
>
> the linux port
>
> Your CL landed before the m22 branch. Did the fix for setIcon() not working
> at
> all make it in before the m22 branch too? Is there a bug for that? Does your
> fix
> need to be merged? (omahaproxy.appspot.com has branch revision numbers)

If I'm right that I broke setIcon(path), then your fix fixes it too.

[commit-bot: I haz the power, 2012-08-10 00:44:01]

Try job failure for 10855090-6002 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-08-10 00:44:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/10855090/14001