Issue 10855087: media galleries dialog fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10855087: media galleries dialog fixes (Closed)

Created:
8 years, 4 months ago by Evan Stade

Modified:
8 years, 4 months ago

Reviewers:
asargent_no_longer_on_chrome, sail

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

media galleries dialog: 1 - fix a crash 2 - remove an ifdef that's no longer required BUG=134929 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151108

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	chrome/browser/media_gallery/media_galleries_dialog_controller.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	chrome/browser/media_gallery/media_galleries_dialog_controller.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

LGTM! Thanks, will send out the cocoa UI soon.