Chromium Code Reviews

Issue 10855085: Revert 117339 - CSS 2.1 failure: inline-table-001 fails (Closed)

Created:
8 years, 4 months ago by Julien - ping for review
Modified:
8 years, 4 months ago
Reviewers:
jchaffraix
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1229/
Visibility:
Public.

Description

Revert 117339 - CSS 2.1 failure: inline-table-001 fails https://bugs.webkit.org/show_bug.cgi?id=84167 Reviewed by Julien Chaffraix. Source/WebCore: Override lastLineBoxBaseline() in RenderTable so that it picks up the baseline of the text in the first row of the table. This allows inline tables to find the correct baseline to align to. Tests: css2.1/20110323/inline-table-001.htm css2.1/20110323/inline-table-002a.htm css2.1/20110323/inline-table-003.htm fast/css/empty-cell-baseline.html * rendering/RenderTable.cpp: (WebCore::getLineBoxBaseline): (WebCore): (WebCore::RenderTable::lastLineBoxBaseline): (WebCore::RenderTable::firstLineBoxBaseline): * rendering/RenderTable.h: (RenderTable): * rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::firstLineBoxBaseline): if a cell is empty it cannot provide a baseline. Tested by fast/css/empty-cell-baseline.html LayoutTests: * css2.1/20110323/inline-table-001.htm: Added. * css2.1/20110323/inline-table-002a.htm: Added. * css2.1/20110323/inline-table-003.htm: Added. From the CSS 2.1 test suite. * fast/css/empty-cell-baseline-expected.html: Added. * fast/css/empty-cell-baseline.html: Added. This ensures we don't take a baseline from an empty cell. * fast/inline-block/001.html: Modified to make expected results clearer. * platform/chromium-linux-x86/css2.1/20110323/inline-table-001-expected.png: Added. * platform/chromium-linux-x86/css2.1/20110323/inline-table-001-expected.txt: Added. * platform/chromium-linux-x86/css2.1/20110323/inline-table-002a-expected.png: Added. * platform/chromium-linux-x86/css2.1/20110323/inline-table-002a-expected.txt: Added. * platform/chromium-linux-x86/css2.1/20110323/inline-table-003-expected.png: Added. * platform/chromium-linux-x86/css2.1/20110323/inline-table-003-expected.txt: Added. * platform/chromium-linux/editing/pasteboard/innerText-inline-table-expected.png: Progression, the baseline of the text in each cell has moved up to where it should be. * platform/chromium-linux/editing/selection/iframe-expected.png: Progression, 'Inline Table' and 'The End' line up with the first row of the inline table. * platform/chromium-linux/editing/selection/inline-table-expected.png: Progression, 'Inline Table' and 'The End' line up with the first row of the inline table. * platform/chromium-linux/editing/selection/table-caret-3-expected.png: Progression, 'foo' and 'baz' line up with the first row of the inline table. * platform/chromium-linux/fast/css-generated-content/inline-display-types-expected.png: Progression, 'Test' and 'content' now line up. * platform/chromium-linux/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png: Progression, the two boxes now line up. * platform/chromium-linux/fast/inline-block/001-expected.png: Progression, the boxes now line up in the same way as FF and Opera. * platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.png: * platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.txt: Progression, the baseline of the text in each cell has moved up to where it should be. * platform/chromium-win/editing/pasteboard/innerText-inline-table-expected.txt: * platform/chromium-win/editing/selection/iframe-expected.txt: * platform/chromium-win/editing/selection/inline-table-expected.txt: * platform/chromium-win/editing/selection/table-caret-3-expected.txt: * platform/chromium-win/fast/css-generated-content/inline-display-types-expected.txt: * platform/chromium-win/fast/inline-block/001-expected.txt: * platform/chromium-win/fast/repaint/float-overflow-expected.txt: * platform/chromium-win/fast/repaint/float-overflow-right-expected.txt: * platform/chromium/test_expectations.txt: * platform/efl/test_expectations.txt: * platform/gtk/test_expectations.txt: * platform/mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: * platform/mac/test_expectations.txt: * platform/qt/test_expectations.txt: * platform/win/Skipped: Text rebaselines. TBR=robert@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125209

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+173 lines, -634 lines)
D LayoutTests/css2.1/20110323/inline-table-001.htm View 1 chunk +0 lines, -49 lines 0 comments
D LayoutTests/css2.1/20110323/inline-table-002a.htm View 1 chunk +0 lines, -21 lines 0 comments
D LayoutTests/css2.1/20110323/inline-table-003.htm View 1 chunk +0 lines, -20 lines 0 comments
D LayoutTests/fast/css/empty-cell-baseline.html View 1 chunk +0 lines, -55 lines 0 comments
D LayoutTests/fast/css/empty-cell-baseline-expected.html View 1 chunk +0 lines, -34 lines 0 comments
M LayoutTests/fast/inline-block/001.html View 1 chunk +10 lines, -15 lines 0 comments
M LayoutTests/platform/chromium-linux/editing/pasteboard/innerText-inline-table-expected.png View Binary file 0 comments
M LayoutTests/platform/chromium-linux/editing/selection/inline-table-expected.png View Binary file 0 comments
M LayoutTests/platform/chromium-linux/editing/selection/table-caret-3-expected.png View Binary file 0 comments
M LayoutTests/platform/chromium-linux/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png View Binary file 0 comments
M LayoutTests/platform/chromium-linux/fast/inline-block/001-expected.png View Binary file 0 comments
M LayoutTests/platform/chromium-win/editing/pasteboard/innerText-inline-table-expected.txt View 1 chunk +11 lines, -11 lines 0 comments
M LayoutTests/platform/chromium-win/editing/selection/iframe-expected.txt View 3 chunks +10 lines, -10 lines 0 comments
M LayoutTests/platform/chromium-win/editing/selection/inline-table-expected.txt View 2 chunks +6 lines, -6 lines 0 comments
M LayoutTests/platform/chromium-win/editing/selection/table-caret-3-expected.txt View 2 chunks +5 lines, -5 lines 0 comments
M LayoutTests/platform/chromium-win/fast/inline-block/001-expected.txt View 1 chunk +35 lines, -74 lines 0 comments
M LayoutTests/platform/chromium-win/fast/repaint/float-overflow-expected.txt View 1 chunk +1 line, -1 line 0 comments
M LayoutTests/platform/chromium-win/fast/repaint/float-overflow-right-expected.txt View 1 chunk +1 line, -1 line 0 comments
M LayoutTests/platform/mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt View 1 chunk +6 lines, -6 lines 0 comments
M LayoutTests/platform/win/Skipped View 24 chunks +81 lines, -294 lines 0 comments
M Source/WebCore/rendering/RenderTable.h View 1 chunk +1 line, -2 lines 0 comments
M Source/WebCore/rendering/RenderTable.cpp View 1 chunk +5 lines, -28 lines 0 comments
M Source/WebCore/rendering/RenderTableSection.cpp View 1 chunk +1 line, -2 lines 0 comments

Messages

Total messages: 1 (0 generated)
Julien - ping for review
8 years, 4 months ago (2012-08-09 21:55:23 UTC) #1

          

Powered by Google App Engine