Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 10855074: Reenable CaptivePortalBrowserTest.TwoBrokenTabs (Closed)

Created:
8 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
8 years, 4 months ago
Reviewers:
jianli, mmenke
CC:
chromium-reviews
Visibility:
Public.

Description

Reenable CaptivePortalTest.TwoBrokenTabs BUG=141497 TEST=test works again Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150817

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M chrome/browser/captive_portal/captive_portal_browsertest.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jochen (gone - plz use gerrit)
plz review should work again after https://chromiumcodereview.appspot.com/10826224/ has landed
8 years, 4 months ago (2012-08-09 13:21:48 UTC) #1
mmenke
On 2012/08/09 13:21:48, jochen wrote: > plz review > > should work again after https://chromiumcodereview.appspot.com/10826224/ ...
8 years, 4 months ago (2012-08-09 14:34:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/10855074/1
8 years, 4 months ago (2012-08-09 15:32:26 UTC) #3
commit-bot: I haz the power
Change committed as 150817
8 years, 4 months ago (2012-08-09 16:53:23 UTC) #4
jianli
CaptivePortalTest.TwoBrokenTabs is still flaky. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=46622 On Thu, Aug 9, 2012 at 9:53 AM, <commit-bot@chromium.org> wrote: ...
8 years, 4 months ago (2012-08-09 20:14:23 UTC) #5
mmenke
Yup, thanks for pointing it out. And I see it's failed on another CQ run ...
8 years, 4 months ago (2012-08-09 20:26:29 UTC) #6
mmenke
8 years, 4 months ago (2012-08-09 20:30:41 UTC) #7
Actually, it's failing everywhere, so rather than revert, I'll disable
everywhere.

Powered by Google App Engine
This is Rietveld 408576698