Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10855072: Add IsTsfAwareRequired method (Closed)

Created:
8 years, 4 months ago by yoichio
Modified:
8 years, 4 months ago
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org, Seigo Nonaka, horo, Hiro Komatsu, cpu_(ooo_6.6-7.5), ananta, robertshield
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add IsTsfAwareRequired method Currently, this method is same as IsMetroProcess. But whether an application must aware TSF is independent from it is under Metro style. So this method will be changed. BUG=137627 TEST=Trybot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151669

Patch Set 1 #

Patch Set 2 : add comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M base/win/metro.h View 1 chunk +4 lines, -0 lines 0 comments Download
M base/win/metro.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
yoichio
please
8 years, 4 months ago (2012-08-09 10:45:53 UTC) #1
Yohei Yukawa
lgtm
8 years, 4 months ago (2012-08-09 13:47:39 UTC) #2
yoichio
Mark: Could you please review?
8 years, 4 months ago (2012-08-10 05:37:24 UTC) #3
yoichio
Add cpu@ as a owner of metro chrome. Could you take a look?
8 years, 4 months ago (2012-08-10 09:13:25 UTC) #4
Mark Mentovai
I defer to cpu.
8 years, 4 months ago (2012-08-11 15:37:57 UTC) #5
cpu_(ooo_6.6-7.5)
lgtm
8 years, 4 months ago (2012-08-14 19:36:56 UTC) #6
Mark Mentovai
LGTM On Aug 14, 2012 3:36 PM, <cpu@chromium.org> wrote: > lgtm > > > > ...
8 years, 4 months ago (2012-08-14 19:51:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/10855072/4
8 years, 4 months ago (2012-08-15 02:19:55 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-08-15 06:42:13 UTC) #9 
Change committed as 151669

Powered by Google App Engine
This is Rietveld 408576698