Issue 10855070: Add shortcut to create new window for GTK content shell.

Issue 10855070: Add shortcut to create new window for GTK content shell. (Closed)

Created:
8 years, 4 months ago by Shouqun Liu

Modified:
8 years, 4 months ago

Reviewers:
jam, jochen (gone - plz use gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add shortcut to create new window for GTK content shell. Use Control+N to create new content shell window. BUG=90445, 120153 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150781

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix nits #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
	M	content/shell/shell.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	content/shell/shell_gtk.cc	View	1	3 chunks	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Shouqun Liu

Hi, this patch adds shortcut to create new window for GTK content shell, thanks for ...

8 years, 4 months ago (2012-08-09 06:29:31 UTC) #1

jochen (gone - plz use gerrit)

LGTM with nits http://codereview.chromium.org/10855070/diff/1/content/shell/shell_gtk.cc File content/shell/shell_gtk.cc (right): http://codereview.chromium.org/10855070/diff/1/content/shell/shell_gtk.cc#newcode239 content/shell/shell_gtk.cc:239: ShellBrowserContext* browserContext = browser_context

8 years, 4 months ago (2012-08-09 08:34:25 UTC) #2

Shouqun Liu

nits fixed, thanks http://codereview.chromium.org/10855070/diff/1/content/shell/shell_gtk.cc File content/shell/shell_gtk.cc (right): http://codereview.chromium.org/10855070/diff/1/content/shell/shell_gtk.cc#newcode239 content/shell/shell_gtk.cc:239: ShellBrowserContext* browserContext = On 2012/08/09 08:34:25, ...

8 years, 4 months ago (2012-08-09 08:39:50 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shouqun.liu@intel.com/10855070/5001

8 years, 4 months ago (2012-08-09 09:16:13 UTC) #5

Change committed as 150781

Expand Messages | Collapse Messages