Issue 10855066: intents: Remove the disposition enum in web intents model.

Issue 10855066: intents: Remove the disposition enum in web intents model. (Closed)

Created:
8 years, 4 months ago by Greg Billock

Modified:
8 years, 4 months ago

Reviewers:
groby-ooo-7-16, Scott Hess - ex-Googler

CC:
chromium-reviews, gbillock+watch_chromium.org, smckay+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

intents: Remove the disposition enum in web intents model. R=groby@chromium.org BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152000

Patch Set 5 : Fix mock type. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -61 lines)			Patch
M	chrome/browser/ui/cocoa/web_intent_sheet_controller_browsertest.mm	View	1 2 3 4	2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/web_intent_sheet_controller_unittest.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_controller.h	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_controller.cc	View	1 2 3	7 chunks	+10 lines, -24 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc	View	1 2	4 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_delegate.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_model.h	View	1 2	3 chunks	+10 lines, -14 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_model.cc	View	1 2	2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_model_unittest.cc	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 13 (0 generated)

Expand Messages | Collapse Messages

groby-ooo-7-16

LGTM post IWYU http://codereview.chromium.org/10855066/diff/3001/chrome/browser/ui/intents/web_intent_picker_controller.cc File chrome/browser/ui/intents/web_intent_picker_controller.cc (right): http://codereview.chromium.org/10855066/diff/3001/chrome/browser/ui/intents/web_intent_picker_controller.cc#newcode51 chrome/browser/ui/intents/web_intent_picker_controller.cc:51: #include "webkit/glue/web_intent_service_data.h" http://codereview.chromium.org/10855066/diff/3001/chrome/browser/ui/intents/web_intent_picker_controller.h File chrome/browser/ui/intents/web_intent_picker_controller.h (right): ...

8 years, 4 months ago (2012-08-10 18:36:30 UTC) #2

Greg Billock

http://codereview.chromium.org/10855066/diff/3001/chrome/browser/ui/intents/web_intent_picker_controller.cc File chrome/browser/ui/intents/web_intent_picker_controller.cc (right): http://codereview.chromium.org/10855066/diff/3001/chrome/browser/ui/intents/web_intent_picker_controller.cc#newcode51 chrome/browser/ui/intents/web_intent_picker_controller.cc:51: On 2012/08/10 18:36:31, groby wrote: > #include "webkit/glue/web_intent_service_data.h" Was ...

8 years, 4 months ago (2012-08-15 18:16:37 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/10855066/8001

8 years, 4 months ago (2012-08-15 18:17:17 UTC) #4

commit-bot: I haz the power

Presubmit check for 10855066-8001 failed and returned exit status 1. Running presubmit commit checks ...

8 years, 4 months ago (2012-08-15 18:17:28 UTC) #5

Greg Billock

On 2012/08/15 18:17:28, I haz the power (commit-bot) wrote: > Presubmit check for 10855066-8001 failed ...

8 years, 4 months ago (2012-08-15 18:33:26 UTC) #6

Scott Hess - ex-Googler

LGTM On 2012/08/15 18:33:26, Greg Billock wrote: > On 2012/08/15 18:17:28, I haz the power ...

8 years, 4 months ago (2012-08-15 19:41:19 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/10855066/8001

8 years, 4 months ago (2012-08-15 20:44:37 UTC) #8

commit-bot: I haz the power

Try job failure for 10855066-8001 (retry) on mac for step "compile" (clobber build). It's a ...

8 years, 4 months ago (2012-08-15 21:49:07 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/10855066/7002

8 years, 4 months ago (2012-08-15 23:38:21 UTC) #10

commit-bot: I haz the power

Try job failure for 10855066-7002 (retry) on mac_rel for step "compile" (clobber build). It's a ...

8 years, 4 months ago (2012-08-16 00:52:23 UTC) #11

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/10855066/13004

8 years, 4 months ago (2012-08-16 21:11:41 UTC) #12

Change committed as 152000

Expand Messages | Collapse Messages