Add a constructor to DefaultWebIntentServices that takes only the "interesting" args.

Add a constructor that takes only the "interesting" args (basically the args that aren't predictably defaulted). This will allow the cleanup a lot of tests and probably some rel code as well.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151150

[Steve McKay, 2012-08-09 00:17:54]

Out for review :)

[Steve McKay, 2012-08-09 00:18:45]

FYI, I'm not updating any current uses of DefaultWebIntentService as that'll
likely cause unwelcome conflicts with some of my existing CLs.

[Steve McKay, 2012-08-10 16:42:16]

Ping.

[Greg Billock, 2012-08-10 17:01:32]

lgtm

http://codereview.chromium.org/10855065/diff/1/chrome/browser/intents/default...
File chrome/browser/intents/default_web_intent_service.cc (right):

http://codereview.chromium.org/10855065/diff/1/chrome/browser/intents/default...
chrome/browser/intents/default_web_intent_service.cc:12:
DefaultWebIntentService::DefaultWebIntentService(const string16& srv_action,
how about putting one arg per line

[Steve McKay, 2012-08-10 17:31:42]

FYI.

http://codereview.chromium.org/10855065/diff/1/chrome/browser/intents/default...
File chrome/browser/intents/default_web_intent_service.cc (right):

http://codereview.chromium.org/10855065/diff/1/chrome/browser/intents/default...
chrome/browser/intents/default_web_intent_service.cc:12:
DefaultWebIntentService::DefaultWebIntentService(const string16& srv_action,
On 2012/08/10 17:01:32, Greg Billock wrote:
> how about putting one arg per line

Done.

[commit-bot: I haz the power, 2012-08-10 17:31:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/smckay@chromium.org/10855065/9003

[commit-bot: I haz the power, 2012-08-10 18:27:16]

Try job failure for 10855065-9003 (retry) on linux_rel for step "update".
It's a second try, previously, step "cacheinvalidation_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-08-10 20:30:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/smckay@chromium.org/10855065/9003

[commit-bot: I haz the power, 2012-08-10 23:24:25]

Change committed as 151150