Issue 10855064: In ScriptBadgeController, don't CHECK for a valid page ID if there was an error,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10855064: In ScriptBadgeController, don't CHECK for a valid page ID if there was an error, (Closed)

Created:
8 years, 4 months ago by not at google - send to devlin

Modified:
8 years, 4 months ago

Reviewers:
Jeffrey Yasskin, koz (OOO until 15th September)

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, benwells, koz (OOO until 15th September)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

In ScriptBadgeController, don't CHECK for a valid page ID if there was an error, nor if there was no page ID on the executing script (possibly handled by the error case). BUG=138323 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150706

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -19 lines)			Patch
	M	chrome/browser/extensions/script_badge_controller.cc	View		2 chunks	+15 lines, -19 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/10855064/1

8 years, 4 months ago (2012-08-09 02:16:07 UTC) #3

Change committed as 150706